-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clearly state the otel config file is a sample that you need to update in your otel col config — in-app edits #2531
Comments
Hi @olha23 ! Do you have a moment to work on some designs for this? Here are some samples we can work with and improve: Mention ingest endpoint and explain what it is Clearly state the otel config file is a sample that you need to update in your otel col config |
@adnanrahic do we need to have also text field here with Tracetest Server hostname and port? or just toggle? |
If there is a way to expose the hostname of the Tracetest server, then we can also add it. Not sure if it is possible. Otherwise, just toggle is fine IMHO. |
@adnanrahic can you check this and say what do you think? https://www.figma.com/file/LBN4SKVPq3ykegrPKbHT2Y/0.8-0.9-Release-Tracetest?type=design&node-id=2658%3A34615&t=sdZbxla4fGRfCkUB-1 |
I think it looks very nice. We can iterate further on the wording. It can be improved. Let's wait for more feedback from the team. |
@olha23 my opinion
|
I am torn on the 'Enable' switch. I am afraid this screen is confusing without a value / altering something (ie 'Saving' usually means you altered something, and this screen just seems to present material). We could:
Or... we can listen to @xoscar on this one - I am not certain of the best choice and do not feel strongly about it (just afraid it is confusing) |
I agree some of this does not make sense "technically" as the endpoint is always enabled. However, I'm thinking about this from the POV of a user. Here's a flow example:
I think that we're okay with not having a toggle, if we write very clear copy and fix the WDYT? |
We have made the screens more clear - closing. |
Describe the enhancement you'd like to see
In the in-app settings for OpenTelemetry-based data store integrations:
In the docs:
Additional context
N/A
The text was updated successfully, but these errors were encountered: