-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update notification api #3
Conversation
@@ -720,7 +720,7 @@ service AlertManager { | |||
summary: "delete resource types" | |||
}; | |||
option (google.api.http) = { | |||
delete: "/v1/resource_type" | |||
delete: "/v1/resource_types" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should remove _
@@ -743,7 +743,7 @@ service AlertManager { | |||
summary: "describe resource filters" | |||
}; | |||
option (google.api.http) = { | |||
get: "/v1/resource_filter" | |||
get: "/v1/resource_filters" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should remove _
@@ -762,7 +762,7 @@ service AlertManager { | |||
summary: "delete resource filters" | |||
}; | |||
option (google.api.http) = { | |||
delete: "/v1/resource_filter" | |||
delete: "/v1/resource_filters" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should remove _
@@ -193,7 +193,7 @@ service AlertManagerCustom { | |||
summary: "describe alerts with resource search" | |||
}; | |||
option (google.api.http) = { | |||
get: "/v1/alert_with_resource" | |||
get: "/v1/alerts_with_resource" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should remove _
@@ -202,7 +202,7 @@ service AlertManagerCustom { | |||
summary: "describe alert details" | |||
}; | |||
option (google.api.http) = { | |||
get: "/v1/alert_detail" | |||
get: "/v1/alert_details" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should remove _
@@ -223,7 +223,7 @@ service AlertManagerCustom { | |||
summary: "describe history detail" | |||
}; | |||
option (google.api.http) = { | |||
get: "/v1/historydetail" | |||
get: "/v1/history_details" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should remove _
…le coroutine on same pod write history within 10 ms
…ed in next version.
…oid migrate running alerts
No description provided.