Support kube-vip #1413
Merged
Support kube-vip #1413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ks-ci-bot
added
kind/feature
24sama
requested changes
Jul 30, 2022
|
Hi @zhouqiu0103 , thanks for your contribution! There are some comments, PTAL. |
24sama
reviewed
Aug 4, 2022
zhouqiu0103
force-pushed
the
add-vip
branch
2 times, most recently
from
5e4651a
to
a27667e
Compare
ks-ci-bot
added
size/XL
zhouqiu0103
force-pushed
the
add-vip
branch
2 times, most recently
from
a745c73
to
b65ab60
Compare
ks-ci-bot
added
size/L
24sama
approved these changes
Aug 9, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 24sama, zhouqiu0103 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ks-ci-bot
added
the
approved
|
/lgtm |
|
LGTM label has been added. Git tree hash: e5bda7f2d635a10f35929695a56abec12ce37320
|
|
@all-contributors please add @zhouqiu0103 for code |
|
I've put up a pull request to add @zhouqiu0103! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Support kube-vip Kubernetes Control Plane Virtual IP and Load-Balancing
Which issue(s) this PR fixes:
Fixes #1374
Special notes for reviewers:
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: