Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add v1.25.5 to k8e binary #1740

Merged
merged 3 commits into from
Feb 21, 2023

Conversation

xiaods
Copy link
Contributor

@xiaods xiaods commented Feb 18, 2023

kubernetes v1.25.5 is new stable long term support version.
k8e distribution now support it.

What type of PR is this?

/kind feature

What this PR does / why we need it:

let k8e support new kube stable version v1.25.5

Prior to Kubernetes 1.24, CNI plugins could also be managed by kubelet using the command line arguments cni-bin-dir and network-plugin. kubernetes 1.24 removes these command line arguments and CNI management is no longer the job of kubelet.

Which issue(s) this PR fixes:

Special notes for reviewers:

Does this PR introduced a user-facing change?

add new kube version v1.25.5 to k8e distributions.

Additional documentation, usage docs, etc.:


@ks-ci-bot ks-ci-bot added kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 18, 2023
kubernetes v1.25.5 is new stable long term support version.

Signed-off-by: Deshi Xiao <xiaods@gmail.com>
@xiaods xiaods changed the title feat: add v1.25.5 to k8e binary WIP: feat: add v1.25.5 to k8e binary Feb 18, 2023
@ks-ci-bot ks-ci-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 18, 2023
before kubernetes v1.24, kubelet can handle cni, after v1.24,
the cni-conf-dir,cni-bin-dir args is dprecated

Signed-off-by: Deshi Xiao <xiaods@gmail.com>
Signed-off-by: Deshi Xiao <xiaods@gmail.com>
@ks-ci-bot ks-ci-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 19, 2023
@xiaods xiaods changed the title WIP: feat: add v1.25.5 to k8e binary feat: add v1.25.5 to k8e binary Feb 19, 2023
@ks-ci-bot ks-ci-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 19, 2023
@zaunist
Copy link
Contributor

zaunist commented Feb 20, 2023

Can we really install version 1.25.5 directly? I tried to install 1.25.3 before and it failed. Have you tested it?

@xiaods
Copy link
Contributor Author

xiaods commented Feb 20, 2023

Can we really install version 1.25.5 directly? I tried to install 1.25.3 before and it failed. Have you tested it?

I am k8e project maintainer. I have already testing v1.25.5 on my cluster. you can have a try.
more details see here: https://getk8e.com/docs/install/210-kubekey/

@zaunist
Copy link
Contributor

zaunist commented Feb 20, 2023

Can we really install version 1.25.5 directly? I tried to install 1.25.3 before and it failed. Have you tested it?

I am k8e project maintainer. I have already testing v1.25.5 on my cluster. you can have a try. more details see here: https://getk8e.com/docs/install/210-kubekey/

Got it.

@24sama
Copy link
Collaborator

24sama commented Feb 21, 2023

Thanks @xiaods !

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2023
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 9f4c0c12f9789bff51519abdadd9588e15f09304

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 24sama, xiaods

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2023
@ks-ci-bot ks-ci-bot merged commit 3578d73 into kubesphere:master Feb 21, 2023
@xiaods xiaods deleted the fix-k8e-version-easy branch February 21, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants