Fix: kubeadm v1beta3 dns config #2104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ks-ci-bot
added
kind/cleanup
vicoooo26
force-pushed
the
fix/kubeadm-v3
branch
from
daaefd1
to
931ea6e
Compare
vicoooo26
force-pushed
the
fix/kubeadm-v3
branch
from
931ea6e
to
d0dd3c0
Compare
|
@vicoooo26 Thanks for this contributions ! |
|
LGTM label has been added. Git tree hash: 0b51a22e16eca59106e8ebd73b340fb62a5fadbf
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pixiake, vicoooo26 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ks-ci-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The "ClusterConfiguration.DNS.Type" field has been removed in the v1beta3 kubeadm config schema since CoreDNS is the only supported DNS server type by kubeadm. If we keep this field in v1beta3 kubeadm configuration, kubeadm will complain about this invalid field and print some warning logs during the installation process.
Which issue(s) this PR fixes:
Special notes for reviewers:
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: