add check support k8s version #2259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ks-ci-bot
added
kind/feature
|
@bzd111 Thanks for this contributions ! /lgtm |
|
LGTM label has been added. Git tree hash: c709e08c77fa6653d0b3098a3aaba085b34a66c7
|
ks-ci-bot
added
the
approved
|
|
@pixiake |
|
/lgtm |
|
LGTM label has been added. Git tree hash: d1da0388aa5532413a20db1f3a62f6bbd47b7282
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bzd111, pixiake The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the following command to create a cluster:
kk create cluster -f cluster.yaml.If a Kubernetes version specified in cluster.yaml is not found in versions/components.json, the installation process should terminate. Instead of exiting after a failed SHA256 comparison following the download.
What type of PR is this?
/kind feature
Optionally add one or more of the following kinds if applicable:
/kind flake
What this PR does / why we need it:
Check the supported k8s versions and terminate early in the precheck.
Special notes for reviewers:
Does this PR introduced a user-facing change?