Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: join control-plane error #2321

Merged
merged 3 commits into from
Jul 16, 2024
Merged

Conversation

redscholar
Copy link
Collaborator

What type of PR is this?

/kind bug

What this PR does / why we need it:

  1. join control-plane error
  2. rescue and always is not execute

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

join control-plane error
rescue and always is not execute

Additional documentation, usage docs, etc.:


joyceliu added 3 commits July 16, 2024 16:19
Signed-off-by: joyceliu <joyceliu@yunify.com>
Signed-off-by: joyceliu <joyceliu@yunify.com>
Signed-off-by: joyceliu <joyceliu@yunify.com>
@ks-ci-bot ks-ci-bot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 16, 2024
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ImitationImmortal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 16, 2024
@pixiake
Copy link
Collaborator

pixiake commented Jul 16, 2024

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2024
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 0783d1c3beaccc9ffda313fb66e47c15c311395c

@ks-ci-bot ks-ci-bot merged commit de9a34f into kubesphere:feature-gitops Jul 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants