Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an unit test example for install command #542

Merged
merged 1 commit into from
May 31, 2021
Merged

Add an unit test example for install command #542

merged 1 commit into from
May 31, 2021

Conversation

lshmouse
Copy link

Ref #540

@ks-ci-bot ks-ci-bot added dco-signoff: no size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 31, 2021
@FeynmanZhou FeynmanZhou requested a review from pixiake May 31, 2021 06:42
@pixiake
Copy link
Collaborator

pixiake commented May 31, 2021

Thanks for the contribution！

@pixiake
Copy link
Collaborator

pixiake commented May 31, 2021

You can add signed-off-by with this command: git commit -s --amend --no-edit

Add an unit test example for install command
46d0bf2 
Signed-off-by: Shaohui Liu <liushaohui@xiaomi.com>
@lshmouse
Copy link
Author

git commit -s --amend --no-edit

done~

pixiake
pixiake reviewed May 31, 2021
View reviewed changes
Copy link
Collaborator

@pixiake pixiake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

pixiake
pixiake reviewed May 31, 2021
View reviewed changes
Copy link
Collaborator

@pixiake pixiake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2021
@pixiake
Copy link
Collaborator

pixiake commented May 31, 2021

/approve

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lshmouse, pixiake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2021
@ks-ci-bot ks-ci-bot merged commit 2b8336a into kubesphere:master May 31, 2021
@pixiake
Copy link
Collaborator

pixiake commented May 31, 2021

@all-contributors please add @lshmouse for code

@allcontributors allcontributors bot mentioned this pull request May 31, 2021
Merged
@allcontributors
Copy link
Contributor

@pixiake

I've put up a pull request to add @lshmouse! 🎉

@FeynmanZhou
Copy link
Member

@lshmouse Thanks for your contribution! Feel free to join our community via the Slack channel or WeChat group. You will find the entry on https://kubesphere.io/.

@pixiake pixiake mentioned this pull request Jun 14, 2021
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixiake pixiake pixiake left review comments

Assignees

@pixiake pixiake

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lshmouse @pixiake @ks-ci-bot @FeynmanZhou