Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor auditing and update wording #354

Merged
merged 1 commit into from
Oct 24, 2020
Merged

Refactor auditing and update wording #354

merged 1 commit into from
Oct 24, 2020

Conversation

Sherlock113
Copy link
Contributor

Signed-off-by: Sherlock113 sherlockxu@yunify.com

@Sherlock113 Sherlock113 added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 13, 2020
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Sherlock113
To complete the pull request process, please assign rayzhou2017
You can assign the PR to them by writing /assign @rayzhou2017 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 13, 2020
@Sherlock113
Refactor auditing and update wording
8474cd2 
Signed-off-by: Sherlock113 <sherlockxu@yunify.com>
@Sherlock113 Sherlock113 removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 13, 2020
@Sherlock113
Copy link
Contributor Author

Sherlock113 commented Oct 13, 2020 •
edited
Loading

/assign @wanjunlei
/cc @FeynmanZhou
The auditing guide is refactored with wording and format updated based on #313 to fix #350.

@FeynmanZhou
Copy link
Member

@wanjunlei Did you review the updates?

@FeynmanZhou FeynmanZhou mentioned this pull request Oct 24, 2020
Open
@FeynmanZhou
Copy link
Member

FeynmanZhou commented Oct 24, 2020 •
edited
Loading

@Sherlock113 @wanjunlei I have reviewed this PR and conclude a couple of questions, please take a look at #376

@wanjunlei Please take a look at the updates in this PR.

@FeynmanZhou FeynmanZhou merged commit e52340f into kubesphere:master Oct 24, 2020
@Sherlock113 Sherlock113 deleted the auditingrefactor branch October 26, 2020 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FeynmanZhou FeynmanZhou Awaiting requested review from FeynmanZhou

@wanjunlei wanjunlei Awaiting requested review from wanjunlei

Assignees

@wanjunlei wanjunlei

Labels
dco-signoff: yes size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sherlock113 @ks-ci-bot @FeynmanZhou @wanjunlei