Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update telemetry guide #372

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Update telemetry guide #372

merged 1 commit into from
Oct 22, 2020

Conversation

Sherlock113
Copy link
Contributor

Signed-off-by: Sherlock113 sherlockxu@yunify.com

Signed-off-by: Sherlock113 <sherlockxu@yunify.com>
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Sherlock113
To complete the pull request process, please assign zryfish
You can assign the PR to them by writing /assign @zryfish in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 22, 2020
@Forest-L
Copy link

/lgtm

@FeynmanZhou
Copy link
Member

@Sherlock113 @Forest-L It would be better to prompt the users on how to disable the telemetry before starting the installation, please also add it in this guide. I will merge it first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants