Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Add true and false staus icons #1250

Merged
merged 1 commit into from
Jun 30, 2024

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Jun 30, 2024

Ref: #1251

Issue:
conditions status has "true" and "false" as values, we do not assign an icon to this values

Fix:
assign plus and minus icons to true and false

Screenshots:
Before:
no-icon

After:
true-icon

Signed-off-by: yaacov <kobi.zamir@gmail.com>
@yaacov yaacov added the bug Categorizes issue or PR as related to a bug. label Jun 30, 2024
@yaacov yaacov added this to the 2.7.0 milestone Jun 30, 2024
@yaacov yaacov merged commit 49bf592 into kubev2v:main Jun 30, 2024
7 checks passed
@yaacov yaacov modified the milestones: 2.7.0, 2.6.3 Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant