You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the ability to add a vSphere provider that connects to SDK that is served by an ESXi host, instead of that of vCenter. This allows users to import directly from environments that comprise of ESXi hosts, without vCenter.
We don't add a new type of provider since most of the code is similar in both cases, the SDK that is exposed from ESXi aligns with the one exposed from vCenter. The only difference is that in case we operate with an ESXi host, we need to set the libvirt URL with esx:// rather than vpx:// for virt-v2v.
For vSphere providers that interact with an ESXi hosts, the backend doesn't assume clients specify the credentials for the host as these credentials were already specified for the provider - a mutating webhook copies the credentials from the secret of the Provider to the secret of the Host in this case.
For vSphere providers that interact with an ESXi hosts, the backend doesn't assume clients specify the credentials for the host as these credentials were already specified for the provider - a mutating webhook copies the credentials from the secret of the Provider to the secret of the Host in this case.
@yaacov that's what we agreed on offline, are you also ok with naming the new setting sdkEndpoint (that can be set to vcenter or esxi)?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ahadas
requested review from
yaacov and
liranr23
and removed request for
liranr23
This PR adds the ability to add a vSphere provider that connects to SDK that is served by an ESXi host, instead of that of vCenter. This allows users to import directly from environments that comprise of ESXi hosts, without vCenter.
We don't add a new type of provider since most of the code is similar in both cases, the SDK that is exposed from ESXi aligns with the one exposed from vCenter. The only difference is that in case we operate with an ESXi host, we need to set the libvirt URL with
esx://rather thanvpx://for virt-v2v.For vSphere providers that interact with an ESXi hosts, the backend doesn't assume clients specify the credentials for the host as these credentials were already specified for the provider - a mutating webhook copies the credentials from the secret of the Provider to the secret of the Host in this case.