Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

embedded metadata schema in CRD is not generated #1730

Closed
captainroy-hy opened this issue May 29, 2021 · 2 comments · Fixed by #2215
Closed

embedded metadata schema in CRD is not generated #1730

captainroy-hy opened this issue May 29, 2021 · 2 comments · Fixed by #2215
Labels
priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough interest in it. type/enhancement New feature or request

Comments

@captainroy-hy
Copy link
Collaborator

captainroy-hy commented May 29, 2021 •
edited
Loading

appRevision.Spec.Application use Application as field type., because of the upstream issue kubernetes-sigs/controller-tools#448, embedded metadata schema cannot be generated. Same issue happens to CompDef,TraitDef used in AppRevision.
That results in the resources(App,CompDefiniton,TraitDefinition) stored in appRevision has no metadata.

Is it by design to omit metadata of these resources?
If not and require to fix. Noticing the upstream issue has been fixed and merged kubernetes-sigs/controller-tools#557 recently, maybe we can consider upgrading controller-gen from v0.2.4 to v0.6.0-beta.0

/cc @wonderflow @yangsoon
@captainroy-hy
Copy link
Collaborator Author

After discussion with @wonderflow. Upgrading dependency is too heavy now. As a workaround, currently we can get app's lables/annots from appRevision.Spec.ApplicationConfiguration.

@wonderflow
Copy link
Collaborator

We should still keep the issue open, until we finally upgrade the dependency.

@wonderflow wonderflow reopened this May 30, 2021
@wonderflow wonderflow changed the title [Bug] embedded metadata schema in CRD is not generated embedded metadata schema in CRD is not generated Jun 4, 2021
@wonderflow wonderflow added type/enhancement New feature or request priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough interest in it. labels Jun 4, 2021
@captainroy-hy captainroy-hy mentioned this issue Aug 31, 2021
Merged
zzxwill added a commit to zzxwill/terraform-controller that referenced this issue Oct 8, 2021
@zzxwill
upgrade controller-gen to v0.6.0 per the suggestion from kubevela/kub…
a96d5d4 
…evela#1730
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough interest in it. type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix(upgrade): upgrade controller-tools from 0.2 to 0.6.2 captainroy-hy/RudrX
2 participants
@wonderflow @captainroy-hy