-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: check the legacy definitions in vela install #5268
Conversation
Codecov ReportBase: 58.46% // Head: 61.14% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5268 +/- ##
==========================================
+ Coverage 58.46% 61.14% +2.68%
==========================================
Files 281 307 +26
Lines 43253 46350 +3097
==========================================
+ Hits 25286 28342 +3056
+ Misses 15205 15088 -117
- Partials 2762 2920 +158
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ff3bc58
to
9d89b19
Compare
Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
* Fix: check the legacy definitions in vela install Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com> * take over views Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
* Fix: check the legacy definitions in vela install Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com> * take over views Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
* Fix: check the legacy definitions in vela install Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com> * take over views Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
…la install
Signed-off-by: FogDong dongtianxin.tx@alibaba-inc.com
Description of your changes
Add vela def check-system and check the legacy definitions in vela install.
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer
cc @barnettZQG @wonderflow