Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: check the legacy definitions in vela install #5268

Merged
merged 2 commits into from
Jan 5, 2023

Conversation

FogDong
Copy link
Member

@FogDong FogDong commented Jan 4, 2023

…la install

Signed-off-by: FogDong dongtianxin.tx@alibaba-inc.com

Description of your changes

Add vela def check-system and check the legacy definitions in vela install.

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

cc @barnettZQG @wonderflow

@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Base: 58.46% // Head: 61.14% // Increases project coverage by +2.68% 🎉

Coverage data is based on head (6414e08) compared to base (03d892b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5268      +/-   ##
==========================================
+ Coverage   58.46%   61.14%   +2.68%     
==========================================
  Files         281      307      +26     
  Lines       43253    46350    +3097     
==========================================
+ Hits        25286    28342    +3056     
+ Misses      15205    15088     -117     
- Partials     2762     2920     +158     
Flag Coverage Δ
apiserver-e2etests 35.55% <ø> (+0.12%) ⬆️
apiserver-unittests 36.33% <ø> (ø)
core-unittests 55.23% <ø> (-0.01%) ⬇️
e2e-multicluster-test 19.02% <ø> (?)
e2e-rollout-tests 20.67% <ø> (?)
e2etests 26.12% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/apiserver/event/sync/worker.go 72.30% <0.00%> (-4.62%) ⬇️
pkg/apiserver/event/sync/cr2ux.go 51.16% <0.00%> (-3.49%) ⬇️
...server/infrastructure/datastore/kubeapi/kubeapi.go 63.43% <0.00%> (-1.11%) ⬇️
pkg/apiserver/event/sync/store.go 71.04% <0.00%> (-0.46%) ⬇️
pkg/addon/registry.go 51.26% <0.00%> (ø)
pkg/cmd/utils.go 27.77% <0.00%> (ø)
pkg/webhook/core.oam.dev/register.go 34.48% <0.00%> (ø)
...g/controller/core.oam.dev/oamruntime_controller.go 100.00% <0.00%> (ø)
...g/controller/core.oam.dev/v1alpha2/core/revison.go 72.66% <0.00%> (ø)
...am.dev/v1alpha2/applicationconfiguration/render.go 0.00% <0.00%> (ø)
... and 97 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@FogDong FogDong force-pushed the fix-install branch 2 times, most recently from ff3bc58 to 9d89b19 Compare January 5, 2023 03:31
references/cli/def.go Outdated Show resolved Hide resolved
references/cli/def.go Outdated Show resolved Hide resolved
Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
@FogDong FogDong changed the title Fix: add vela def check-system and check the legacy definitions in vela install Fix: check the legacy definitions in vela install Jan 5, 2023
@barnettZQG barnettZQG merged commit af8a7eb into kubevela:master Jan 5, 2023
callmeoldprince pushed a commit to callmeoldprince/kubevela that referenced this pull request Jan 6, 2023
* Fix: check the legacy definitions in vela install

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>

* take over views

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
barnettZQG pushed a commit to barnettZQG/kubevela that referenced this pull request Jan 30, 2023
* Fix: check the legacy definitions in vela install

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>

* take over views

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
zhaohuiweixiao pushed a commit to zhaohuiweixiao/kubevela that referenced this pull request Mar 7, 2023
* Fix: check the legacy definitions in vela install

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>

* take over views

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants