Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: cherry pick 5404 to 1.6 #5409

Merged

Conversation

wangyikewxgm
Copy link
Collaborator

@wangyikewxgm wangyikewxgm commented Feb 2, 2023

cherry pick 5404 to 1.6

Signed-off-by: 楚岳 wangyike.wyk@alibaba-inc.com

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Base: 46.44% // Head: 61.69% // Increases project coverage by +15.24% 🎉

Coverage data is based on head (d8e0100) compared to base (51d536e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.6    #5409       +/-   ##
================================================
+ Coverage        46.44%   61.69%   +15.24%     
================================================
  Files              251      304       +53     
  Lines            30423    33409     +2986     
================================================
+ Hits             14131    20612     +6481     
+ Misses           14220    10019     -4201     
- Partials          2072     2778      +706     
Flag Coverage Δ
apiserver-e2etests 35.83% <ø> (?)
apiserver-unittests 37.20% <ø> (-0.03%) ⬇️
core-unittests 55.17% <ø> (-0.11%) ⬇️
e2e-multicluster-test 18.82% <ø> (?)
e2e-rollout-tests 20.27% <ø> (?)
e2etests 25.89% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/addon/registry.go 37.34% <0.00%> (-8.44%) ⬇️
pkg/apiserver/domain/model/user.go 79.31% <0.00%> (ø)
pkg/apiserver/domain/model/pipeline.go 100.00% <0.00%> (ø)
...alpha2/applicationconfiguration/controllerhooks.go 0.00% <0.00%> (ø)
version/version.go 20.00% <0.00%> (ø)
...plicationconfiguration/applicationconfiguration.go 0.00% <0.00%> (ø)
pkg/apiserver/domain/model/model.go 50.00% <0.00%> (ø)
pkg/apiserver/domain/model/system_info.go 100.00% <0.00%> (ø)
pkg/apiserver/domain/model/envbinding.go 100.00% <0.00%> (ø)
pkg/monitor/watcher/application.go 96.22% <0.00%> (ø)
... and 199 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wonderflow wonderflow merged commit 6553a90 into kubevela:release-1.6 Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants