Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: update sharding using pkg #5430

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

Somefive
Copy link
Collaborator

@Somefive Somefive commented Feb 6, 2023

Signed-off-by: Somefive yd219913@alibaba-inc.com

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Base: 57.41% // Head: 59.41% // Increases project coverage by +2.00% 🎉

Coverage data is based on head (9550bdc) compared to base (46d762f).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head 9550bdc differs from pull request most recent head 38e27c9. Consider uploading reports for the commit 38e27c9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5430      +/-   ##
==========================================
+ Coverage   57.41%   59.41%   +2.00%     
==========================================
  Files         315      305      -10     
  Lines       47307    46933     -374     
==========================================
+ Hits        27160    27885     +725     
+ Misses      17335    16126    -1209     
- Partials     2812     2922     +110     
Flag Coverage Δ
apiserver-e2etests 35.61% <0.00%> (+0.11%) ⬆️
apiserver-unittests 36.31% <ø> (?)
core-unittests 55.29% <0.00%> (+0.11%) ⬆️
e2e-multicluster-test ?
e2e-rollout-tests 20.72% <0.00%> (+0.09%) ⬆️
e2etests 26.20% <0.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/core/app/options/options.go 92.79% <ø> (ø)
cmd/core/app/server.go 52.29% <0.00%> (-6.43%) ⬇️
...ller/core.oam.dev/v1alpha2/application/revision.go 69.58% <ø> (-2.20%) ⬇️
pkg/resourcetracker/app.go 86.80% <ø> (ø)
pkg/utils/app/reschedule.go 64.28% <ø> (ø)
...e.oam.dev/v1alpha2/application/mutating_handler.go 74.32% <0.00%> (-12.17%) ⬇️
...ok/core.oam.dev/v1alpha2/application/validation.go 82.85% <ø> (-2.86%) ⬇️
pkg/monitor/watcher/application.go 0.00% <0.00%> (-97.06%) ⬇️
pkg/auth/identity.go 8.45% <0.00%> (-67.61%) ⬇️
pkg/resourcetracker/tree.go 18.49% <0.00%> (-53.97%) ⬇️
... and 89 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Somefive <yd219913@alibaba-inc.com>
@Somefive Somefive force-pushed the feat/update-sharding-using-pkg branch from 9550bdc to 38e27c9 Compare February 7, 2023 02:05
@FogDong FogDong merged commit e2f95e0 into kubevela:master Feb 7, 2023
@Somefive Somefive deleted the feat/update-sharding-using-pkg branch February 7, 2023 03:28
zhaohuiweixiao pushed a commit to zhaohuiweixiao/kubevela that referenced this pull request Mar 7, 2023
Signed-off-by: Somefive <yd219913@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants