Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: remove unnecessary go mod #6093

Merged

Conversation

Somefive
Copy link
Collaborator

@Somefive Somefive commented Jun 8, 2023

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Patch coverage: 44.44% and project coverage change: -0.05 ⚠️

Comparison is base (be3b990) 66.51% compared to head (f6af729) 66.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6093      +/-   ##
==========================================
- Coverage   66.51%   66.47%   -0.05%     
==========================================
  Files         191      191              
  Lines       24852    24780      -72     
==========================================
- Hits        16531    16472      -59     
+ Misses       6724     6707      -17     
- Partials     1597     1601       +4     
Flag Coverage Δ
core-unittests 55.22% <22.22%> (+0.05%) ⬆️
e2e-multicluster-test 30.74% <22.22%> (-0.02%) ⬇️
e2etests 33.52% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cmd/utils.go 28.57% <ø> (+0.79%) ⬆️
pkg/config/writer/writer.go 51.04% <ø> (ø)
pkg/utils/common/common.go 51.66% <ø> (-5.71%) ⬇️
pkg/utils/env/env.go 10.43% <28.57%> (+0.84%) ⬆️
pkg/appfile/appfile.go 69.83% <100.00%> (ø)
pkg/component/ref_objects.go 82.45% <100.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Somefive <yd219913@alibaba-inc.com>
@Somefive Somefive force-pushed the chore/remove-unnecessary-go-mod branch from 25e69ee to f6af729 Compare June 8, 2023 03:33
@wangyikewxgm wangyikewxgm merged commit c255d21 into kubevela:master Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants