Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: support cuex #33

Merged
merged 8 commits into from
Jan 17, 2023
Merged

Feat: support cuex #33

merged 8 commits into from
Jan 17, 2023

Conversation

Somefive
Copy link
Collaborator

@Somefive Somefive commented Jan 9, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Base: 90.90% // Head: 90.35% // Decreases project coverage by -0.55% ⚠️

Coverage data is based on head (5912301) compared to base (302624c).
Patch coverage: 89.95% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
- Coverage   90.90%   90.35%   -0.56%     
==========================================
  Files          15       49      +34     
  Lines         352     1006     +654     
==========================================
+ Hits          320      909     +589     
- Misses         19       58      +39     
- Partials       13       39      +26     
Flag Coverage Δ
unit-test 90.35% <89.95%> (-0.56%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
util/compression/gzip.go 60.00% <60.00%> (ø)
cue/util/string.go 66.66% <66.66%> (ø)
cue/cuex/compiler.go 73.07% <73.07%> (ø)
multicluster/client.go 83.67% <75.00%> (+1.06%) ⬆️
cue/cuex/error.go 77.77% <77.77%> (ø)
cue/cuex/runtime/package.go 77.77% <77.77%> (ø)
cue/util/import.go 77.77% <77.77%> (ø)
cue/cuex/runtime/packagemanager.go 78.43% <78.43%> (ø)
util/singleton/client.go 78.94% <78.94%> (ø)
cue/cuex/providers/http/http.go 80.00% <80.00%> (ø)
... and 32 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Somefive Somefive force-pushed the feat/cuex branch 2 times, most recently from 3f4d993 to 96c9bef Compare January 10, 2023 03:16
@Somefive Somefive force-pushed the feat/cuex branch 2 times, most recently from 6eb123d to aff2ba1 Compare January 10, 2023 08:36
Signed-off-by: Yin Da <yd219913@alibaba-inc.com>
Signed-off-by: Yin Da <yd219913@alibaba-inc.com>
Signed-off-by: Yin Da <yd219913@alibaba-inc.com>
cue/cuex/README.md Outdated Show resolved Hide resolved
cue/cuex/runtime/provider.go Show resolved Hide resolved
cue/cuex/compiler.go Outdated Show resolved Hide resolved
cue/cuex/compiler.go Outdated Show resolved Hide resolved
@Somefive Somefive force-pushed the feat/cuex branch 2 times, most recently from 6b2dd41 to d17f9fb Compare January 16, 2023 08:42
Signed-off-by: Yin Da <yd219913@alibaba-inc.com>
cue/util/iterate.go Outdated Show resolved Hide resolved
Signed-off-by: Yin Da <yd219913@alibaba-inc.com>
Signed-off-by: Yin Da <yd219913@alibaba-inc.com>
Signed-off-by: Yin Da <yd219913@alibaba-inc.com>
Signed-off-by: Yin Da <yd219913@alibaba-inc.com>
Copy link
Member

@FogDong FogDong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work!

After the PR is merged, we can add a lint-check action and lint the code.

@Somefive Somefive merged commit fc80cfb into kubevela:main Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants