Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: optimize log flag #36

Merged
merged 2 commits into from
Jan 18, 2023
Merged

Conversation

Somefive
Copy link
Collaborator

Signed-off-by: Yin Da yd219913@alibaba-inc.com

@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Base: 90.54% // Head: 90.36% // Decreases project coverage by -0.19% ⚠️

Coverage data is based on head (7a7c469) compared to base (6dc6228).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 7a7c469 differs from pull request most recent head a84df55. Consider uploading reports for the commit a84df55 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
- Coverage   90.54%   90.36%   -0.19%     
==========================================
  Files          49       49              
  Lines        1492     1007     -485     
==========================================
- Hits         1351      910     -441     
+ Misses        102       58      -44     
  Partials       39       39              
Flag Coverage Δ
unit-test 90.36% <100.00%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
util/log/flag.go 100.00% <100.00%> (ø)
util/net/http.go 50.00% <0.00%> (-5.56%) ⬇️
controller/client/timeout_client.go 92.85% <0.00%> (-2.23%) ⬇️
cue/cuex/error.go 77.77% <0.00%> (-2.23%) ⬇️
multicluster/client.go 83.67% <0.00%> (-1.47%) ⬇️
util/compression/data.go 80.00% <0.00%> (-1.40%) ⬇️
util/singleton/client.go 78.94% <0.00%> (-1.06%) ⬇️
cue/util/import.go 77.77% <0.00%> (-0.80%) ⬇️
cue/cuex/runtime/package.go 77.77% <0.00%> (-0.80%) ⬇️
... and 40 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Yin Da <yd219913@alibaba-inc.com>
@Somefive Somefive merged commit f5699a6 into kubevela:main Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants