Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: use gvk instead of group resource in resource indentifier #63

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

FogDong
Copy link
Member

@FogDong FogDong commented Mar 15, 2023

No description provided.

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
@FogDong FogDong requested a review from Somefive as a code owner March 15, 2023 10:07
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Patch coverage: 97.50% and project coverage change: +0.13 🎉

Comparison is base (ff5ddf7) 90.43% compared to head (97ef1f0) 90.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
+ Coverage   90.43%   90.56%   +0.13%     
==========================================
  Files          64       64              
  Lines        2414     2416       +2     
==========================================
+ Hits         2183     2188       +5     
+ Misses        168      166       -2     
+ Partials       63       62       -1     
Flag Coverage Δ
unit-test 90.56% <97.50%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
util/resourcetopology/topology.go 94.48% <97.14%> (-1.03%) ⬇️
util/k8s/resource.go 91.17% <100.00%> (+15.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants