Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add utility #88

Merged
merged 2 commits into from
Jun 13, 2023
Merged

Feat: add utility #88

merged 2 commits into from
Jun 13, 2023

Conversation

Somefive
Copy link
Collaborator

@Somefive Somefive commented Jun 12, 2023

  1. Add hash.
  2. Add CopyInto & FieldPath for jsonutil.
  3. Migrate apply client from kubevela main repo.
  4. Update patch pkg for main repo use.

@Somefive Somefive requested a review from FogDong as a code owner June 12, 2023 03:09
@Somefive Somefive marked this pull request as draft June 12, 2023 03:09
@Somefive Somefive force-pushed the feat/add-utility branch 4 times, most recently from f40565b to e37ab18 Compare June 12, 2023 03:17
Signed-off-by: Yin Da <yd219913@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Patch coverage: 93.54% and project coverage change: +0.38 🎉

Comparison is base (c34f8f7) 87.47% compared to head (2a03e98) 87.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
+ Coverage   87.47%   87.85%   +0.38%     
==========================================
  Files          78       81       +3     
  Lines        3744     3871     +127     
==========================================
+ Hits         3275     3401     +126     
- Misses        354      357       +3     
+ Partials      115      113       -2     
Flag Coverage Δ
unit-test 87.85% <93.54%> (+0.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
util/hash/hash.go 57.14% <57.14%> (ø)
util/k8s/patch/patch.go 85.91% <83.33%> (+6.18%) ⬆️
util/k8s/apply/client.go 94.11% <94.11%> (ø)
util/jsonutil/convert.go 100.00% <100.00%> (ø)
util/jsonutil/fieldpath.go 100.00% <100.00%> (ø)
util/k8s/object.go 96.20% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Somefive Somefive force-pushed the feat/add-utility branch 6 times, most recently from e5a90df to a4589c6 Compare June 13, 2023 03:41
Signed-off-by: Yin Da <yd219913@alibaba-inc.com>
@Somefive Somefive marked this pull request as ready for review June 13, 2023 04:01
@FogDong FogDong merged commit 2cef0c3 into kubevela:main Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants