-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: support label filter for application list #712
Feat: support label filter for application list #712
Conversation
Signed-off-by: Basuotian <basuoluomiu@gmail.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #712 +/- ##
==========================================
+ Coverage 58.83% 60.40% +1.57%
==========================================
Files 94 94
Lines 17596 17622 +26
==========================================
+ Hits 10352 10645 +293
+ Misses 5925 5670 -255
+ Partials 1319 1307 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 27 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Basuotian <basuoluomiu@gmail.com>
Signed-off-by: Basuotian <basuoluomiu@gmail.com>
Signed-off-by: Basuotian <basuoluomiu@gmail.com>
Signed-off-by: Basuotian <basuoluomiu@gmail.com>
Signed-off-by: Basuotian <basuoluomiu@gmail.com>
Signed-off-by: Basuotian <basuoluomiu@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can I write a custom label selector?
Signed-off-by: Basuotian <basuoluomiu@gmail.com>
@basuotian The label selector could be very large scale, how do you get these labels? I'm very concerned about the memery usage. |
But the current experience that we can auto-discovery the label selector is good |
Generated by traverse existing application list, the memory usage may be hard to avoid... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of your changes
Close: #240
support label-based selector for application management, hiding label with prefix
ux.oam.dev
andapp.oam.dev
in table mode, fold up labels in default
expand all labels
click label tag will invoke label filter
Fixes #
I have:
yarn lint
to ensure the frontend changes are ready for review.make reviewable
to ensure the server changes are ready for review.backport release-x.y
labels to auto-backport this PR if necessary.Special notes for your reviewer