Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: support label filter for application list #712

Merged
merged 8 commits into from
Mar 23, 2023

Conversation

basuotian
Copy link
Contributor

@basuotian basuotian commented Mar 20, 2023

Description of your changes

Close: #240

support label-based selector for application management, hiding label with prefix ux.oam.dev and app.oam.dev

image

in table mode, fold up labels in default

image

expand all labels

image

click label tag will invoke label filter

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run yarn lint to ensure the frontend changes are ready for review.
  • Run make reviewableto ensure the server changes are ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer

Signed-off-by: Basuotian <basuoluomiu@gmail.com>
@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +1.57 🎉

Comparison is base (757e727) 58.83% compared to head (d2e5143) 60.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #712      +/-   ##
==========================================
+ Coverage   58.83%   60.40%   +1.57%     
==========================================
  Files          94       94              
  Lines       17596    17622      +26     
==========================================
+ Hits        10352    10645     +293     
+ Misses       5925     5670     -255     
+ Partials     1319     1307      -12     
Flag Coverage Δ
apiserver-unittests 32.06% <0.00%> (-0.01%) ⬇️
server-e2e-tests 49.70% <100.00%> (+4.76%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/server/interfaces/api/dto/v1/types.go 73.33% <ø> (ø)
pkg/server/interfaces/api/application.go 60.89% <100.00%> (+0.94%) ⬆️

... and 27 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@basuotian basuotian changed the title [WIP]Feat: support label filter for application list Feat: support label filter for application list Mar 20, 2023
Signed-off-by: Basuotian <basuoluomiu@gmail.com>
Signed-off-by: Basuotian <basuoluomiu@gmail.com>
Signed-off-by: Basuotian <basuoluomiu@gmail.com>
Signed-off-by: Basuotian <basuoluomiu@gmail.com>
Signed-off-by: Basuotian <basuoluomiu@gmail.com>
Signed-off-by: Basuotian <basuoluomiu@gmail.com>
Copy link
Contributor

@wonderflow wonderflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can I write a custom label selector?

@basuotian
Copy link
Contributor Author

The label selector list comes from actual application labels, you can search with input content, nonexistent custom label selector would not get any applications

image

Signed-off-by: Basuotian <basuoluomiu@gmail.com>
@wonderflow
Copy link
Contributor

@basuotian The label selector could be very large scale, how do you get these labels? I'm very concerned about the memery usage.

@wonderflow
Copy link
Contributor

But the current experience that we can auto-discovery the label selector is good

@basuotian
Copy link
Contributor Author

basuotian commented Mar 23, 2023

@basuotian The label selector could be very large scale, how do you get these labels? I'm very concerned about the memery usage.

Generated by traverse existing application list, the memory usage may be hard to avoid...

Copy link
Collaborator

@barnettZQG barnettZQG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barnettZQG barnettZQG merged commit c312e3f into kubevela:main Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add Labels in Application Card ,support quick editing and query filter
3 participants