Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add a helm type of application, the warehouse drop-down box is empty #733

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Fix: Add a helm type of application, the warehouse drop-down box is empty #733

merged 1 commit into from
Mar 29, 2023

Conversation

jiaxiaolei007
Copy link
Contributor

Description of your changes

Add a helm type of application, the interface does return data but the warehouse drop-down box is empty。

5f23

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run yarn lint to ensure the frontend changes are ready for review.
  • Run make reviewableto ensure the server changes are ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer

@jiaxiaolei007 jiaxiaolei007 changed the title Fix:Add a helm type of application, the warehouse drop-down box is empty Fix: Add a helm type of application, the warehouse drop-down box is empty Mar 29, 2023
@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Patch coverage has no change and project coverage change: +10.57 🎉

Comparison is base (5e7c098) 49.79% compared to head (97a69c1) 60.36%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #733       +/-   ##
===========================================
+ Coverage   49.79%   60.36%   +10.57%     
===========================================
  Files          99       99               
  Lines       17974    17974               
===========================================
+ Hits         8950    10850     +1900     
+ Misses       7863     5782     -2081     
- Partials     1161     1342      +181     
Flag Coverage Δ
apiserver-unittests 32.17% <ø> (?)
server-e2e-tests 49.78% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 37 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@barnettZQG barnettZQG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants