Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add the plugin management API #747

Merged
merged 9 commits into from
Apr 11, 2023

Conversation

chivalryq
Copy link
Member

@chivalryq chivalryq commented Apr 7, 2023

Co-authored by: barnettZQG barnett.zqg@gmail.com

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run yarn lint to ensure the frontend changes are ready for review.
  • Run make reviewableto ensure the server changes are ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer

barnettZQG and others added 2 commits April 6, 2023 15:12
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Patch coverage: 60.33% and project coverage change: -0.03 ⚠️

Comparison is base (6b33036) 61.09% compared to head (bbb65f5) 61.06%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #747      +/-   ##
==========================================
- Coverage   61.09%   61.06%   -0.03%     
==========================================
  Files         106      106              
  Lines       18543    18867     +324     
==========================================
+ Hits        11328    11521     +193     
- Misses       5823     5931     +108     
- Partials     1392     1415      +23     
Flag Coverage Δ
apiserver-unittests 33.69% <33.46%> (+0.55%) ⬆️
server-e2e-tests 49.96% <54.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/plugin/proxy/kube_service_proxy.go 40.90% <0.00%> (-1.95%) ⬇️
pkg/plugin/types/plugin.go 40.00% <ø> (ø)
pkg/server/interfaces/api/dto/v1/types.go 73.33% <ø> (ø)
pkg/server/server.go 56.15% <55.55%> (-0.02%) ⬇️
pkg/server/interfaces/api/plugin.go 58.16% <57.02%> (-13.26%) ⬇️
pkg/server/domain/service/plugin.go 65.91% <61.11%> (-8.37%) ⬇️
pkg/server/interfaces/api/assembler/v1/do2dto.go 87.54% <68.18%> (-4.44%) ⬇️
pkg/server/domain/service/rbac.go 68.87% <72.72%> (-0.03%) ⬇️
pkg/server/domain/model/plugin.go 100.00% <100.00%> (+50.00%) ⬆️
pkg/server/interfaces/api/interfaces.go 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>

add enabled filed to mangedPluginDTO

Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>

Add mergeMap ut

Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>

remove focus

Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
Copy link
Collaborator

@barnettZQG barnettZQG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@barnettZQG barnettZQG merged commit e2a7096 into kubevela:main Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants