Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Simplify the workspace menus #766

Merged
merged 3 commits into from
Apr 14, 2023
Merged

Conversation

barnettZQG
Copy link
Collaborator

Description of your changes

image

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run yarn lint to ensure the frontend changes are ready for review.
  • Run make reviewableto ensure the server changes are ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer

/cc @wonderflow

@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Patch coverage: 62.16% and project coverage change: +0.12 🎉

Comparison is base (7a3ea7d) 61.05% compared to head (63168a1) 61.18%.

❗ Current head 63168a1 differs from pull request most recent head c5565eb. Consider uploading reports for the commit c5565eb to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #766      +/-   ##
==========================================
+ Coverage   61.05%   61.18%   +0.12%     
==========================================
  Files         106      106              
  Lines       18961    18988      +27     
==========================================
+ Hits        11576    11617      +41     
+ Misses       5961     5951      -10     
+ Partials     1424     1420       -4     
Flag Coverage Δ
apiserver-unittests 33.65% <62.16%> (+0.07%) ⬆️
server-e2e-tests 49.97% <16.21%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/server/interfaces/api/dto/v1/types.go 73.33% <ø> (ø)
pkg/server/domain/service/user.go 55.94% <62.16%> (+1.29%) ⬆️

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
Signed-off-by: barnettZQG <barnett.zqg@gmail.com>
@yangsoon yangsoon merged commit 17d562e into kubevela:main Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants