Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: support to approve, terminate and rollback workflow by custom triggers #797

Merged
merged 12 commits into from
Jun 1, 2023

Conversation

NeerajGartia21
Copy link
Collaborator

@NeerajGartia21 NeerajGartia21 commented Apr 27, 2023

Description of your changes

Fixes #734

This PR adds the support to approve, terminate and rollback workflow by custom triggers

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run yarn lint to ensure the frontend changes are ready for review.
  • Run make reviewableto ensure the server changes are ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer

Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>
@NeerajGartia21 NeerajGartia21 changed the title Support to approve, terminate and rollback workflow by custom triggers Feat:Support to approve, terminate and rollback workflow by custom triggers Apr 27, 2023
@NeerajGartia21 NeerajGartia21 changed the title Feat:Support to approve, terminate and rollback workflow by custom triggers Feat: support to approve, terminate and rollback workflow by custom triggers Apr 27, 2023
@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Patch coverage: 65.00% and project coverage change: +0.10 🎉

Comparison is base (0ad6d36) 61.13% compared to head (826b051) 61.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #797      +/-   ##
==========================================
+ Coverage   61.13%   61.24%   +0.10%     
==========================================
  Files         109      109              
  Lines       19143    19209      +66     
==========================================
+ Hits        11703    11764      +61     
- Misses       5989     5991       +2     
- Partials     1451     1454       +3     
Flag Coverage Δ
apiserver-unittests 33.83% <65.00%> (+0.02%) ⬆️
server-e2e-tests 49.71% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/server/interfaces/api/dto/v1/types.go 73.33% <ø> (ø)
pkg/server/domain/service/webhook.go 66.03% <65.00%> (-0.45%) ⬇️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

NeerajGartia21 and others added 7 commits April 28, 2023 23:54
Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>
Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>
Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>
Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>
Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>
@NeerajGartia21 NeerajGartia21 marked this pull request as ready for review May 15, 2023 19:04
@NeerajGartia21
Copy link
Collaborator Author

I think this PR is now ready for review.

Copy link
Member

@chivalryq chivalryq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase the master to run e2e test

pkg/server/domain/service/webhook.go Outdated Show resolved Hide resolved
pkg/server/domain/service/webhook.go Show resolved Hide resolved
@chivalryq
Copy link
Member

Documents should be modified:

Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>
Signed-off-by: Neeraj Gartia <neerajgartia211002@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Support to approve the workflow by the custom trigger
3 participants