Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add docker-build makefile #837

Merged
merged 4 commits into from
Jun 12, 2023
Merged

Feat: add docker-build makefile #837

merged 4 commits into from
Jun 12, 2023

Conversation

nuclearwu
Copy link
Contributor

@nuclearwu nuclearwu commented Jun 8, 2023

Signed-off-by: wuzhongjian wuzhongjian_yewu@cmss.chinamobile.com

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run yarn lint to ensure the frontend changes are ready for review.
  • Run make reviewableto ensure the server changes are ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

Special notes for your reviewer

Signed-off-by: wuzhongjian <wuzhongjian_yewu@cmss.chinamobile.com>
makefiles/build.mk Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.08 ⚠️

Comparison is base (80a0acc) 60.95% compared to head (cd71788) 60.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #837      +/-   ##
==========================================
- Coverage   60.95%   60.87%   -0.08%     
==========================================
  Files         109      110       +1     
  Lines       19375    19406      +31     
==========================================
+ Hits        11810    11814       +4     
- Misses       6099     6127      +28     
+ Partials     1466     1465       -1     
Flag Coverage Δ
apiserver-unittests 33.89% <ø> (+0.03%) ⬆️
server-e2e-tests 49.16% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: wuzhongjian <wuzhongjian_yewu@cmss.chinamobile.com>
@chivalryq
Copy link
Member

/retest-failed

@chivalryq chivalryq changed the title Feat: add docker-build-velaux makefile Feat: add docker-build makefile Jun 9, 2023
Signed-off-by: wuzhongjian <wuzhongjian_yewu@cmss.chinamobile.com>
@nuclearwu nuclearwu requested a review from chivalryq June 12, 2023 01:12
@chivalryq chivalryq merged commit 2931e13 into kubevela:main Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants