Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: refactor test #105

Merged
merged 1 commit into from
Dec 21, 2022
Merged

Chore: refactor test #105

merged 1 commit into from
Dec 21, 2022

Conversation

Somefive
Copy link
Contributor

Signed-off-by: Yin Da yd219913@alibaba-inc.com

Description of your changes

Remove NewLineReporter since controller-runtime new version remove it.

Reference: kubernetes/kubernetes#110319

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Base: 68.39% // Head: 68.39% // No change to project coverage 👍

Coverage data is based on head (92580c4) compared to base (3053ee2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #105   +/-   ##
=======================================
  Coverage   68.39%   68.39%           
=======================================
  Files          49       49           
  Lines        4351     4351           
=======================================
  Hits         2976     2976           
  Misses        998      998           
  Partials      377      377           
Flag Coverage Δ
e2etests 25.55% <ø> (ø)
unit-test 65.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Yin Da <yd219913@alibaba-inc.com>
@FogDong FogDong merged commit 81d587e into kubevela:main Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants