Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-0.4] Fix: add requeue in skip and optimize readme #121

Merged
merged 1 commit into from
Jan 17, 2023
Merged

[Backport release-0.4] Fix: add requeue in skip and optimize readme #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,12 @@ Please checkout: [Install Vela CLI](https://kubevela.io/docs/installation/kubern
- [Custom Context Data](https://kubevela.io/docs/next/end-user/pipeline/workflowrun#custom-context-data)
- [Built-in Context Data](https://kubevela.io/docs/next/end-user/pipeline/workflowrun#built-in-context-data)

## How to write custom steps
## Step Types

### Built-in Step Types

Please checkout the [built-in step definitions](https://kubevela.io/docs/next/end-user/workflow/built-in-workflow-defs) with scope that valid in `WorkflowRun`.
### Write Your Custom Step Types

If you're not familiar with CUE, please checkout the [CUE documentation](https://kubevela.io/docs/platform-engineers/cue/basic) first.

Expand Down
2 changes: 1 addition & 1 deletion controllers/workflowrun_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ func (r *WorkflowRunReconciler) Reconcile(ctx context.Context, req ctrl.Request)
return ctrl.Result{}, patcher.patchStatus(logCtx, &run.Status, isUpdate)
case v1alpha1.WorkflowStateSkipped:
logCtx.Info("Skip this reconcile")
return ctrl.Result{}, nil
return ctrl.Result{RequeueAfter: executor.GetBackoffWaitTime()}, nil
}

return ctrl.Result{}, nil
Expand Down
Loading