Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-35729: Improve modal save while there are changes occurred in the back-end - part 1 disks #1754

Merged

Conversation

avivtur
Copy link
Member

@avivtur avivtur commented Jan 28, 2024

📝 Description

Changing from using k8sUpdate to K8sPatch as it can cause the promise to fail if the VM has changed

🎥 Demo

Please add a video or an image of the behavior/changes

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jan 28, 2024

@avivtur: This pull request references CNV-35729 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

Changing from using k8sUpdate to K8sPatch as it can cause the promise to fail if the VM has changed

🎥 Demo

Please add a video or an image of the behavior/changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Jan 28, 2024
… back-end

Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
@avivtur avivtur force-pushed the change-k8supdate-to-k8spatch branch from 7ad1154 to 0fcaee4 Compare January 29, 2024 11:15
@avivtur avivtur changed the title [wip] CNV-35729: Improve modal save while there are changes occurred in the back-end - part 1 CNV-35729: Improve modal save while there are changes occurred in the back-end - part 1 disks Jan 29, 2024
@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Jan 29, 2024
Copy link
Contributor

openshift-ci bot commented Jan 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, hstastna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit eaef5bc into kubevirt-ui:main Jan 29, 2024
9 checks passed
@pcbailey
Copy link
Member

/cherry-pick release-4.15

@openshift-cherrypick-robot
Copy link
Collaborator

@pcbailey: new pull request created: #1801

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants