CNV-41590: sysprep volume missing on creation of a VM with Sysprep #1998
Conversation
|
@avivtur: This pull request references CNV-41590 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@avivtur: This pull request references CNV-41590 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
| @@ -47,6 +48,9 @@ type GenerateNewSysprepConfigInputType = { | |||
| withOwnerReference?: boolean; | |||
| }; | |||
|
|
|||
| export const generateSysprepConfigMapName = (vmName: string) => | |||
There was a problem hiding this comment.
we have generate pretty name and u can send a prefix
| namespace: vm?.metadata?.namespace, | ||
| ownerReferences: withOwnerReference | ||
| ? [buildOwnerReference(vm, { blockOwnerDeletion: false })] | ||
| : null, | ||
| }, | ||
| }); | ||
|
|
||
| type GenerateNewSysprepConfigInputType2 = { |
| @@ -4,6 +4,9 @@ import { useK8sWatchResource, WatchK8sResult } from '@openshift-console/dynamic- | |||
|
|
|||
| import { AUTOUNATTEND, UNATTEND } from '../sysprep-utils'; | |||
|
|
|||
| const checkEqualCaseInsensitive = (a: string, b: string) => | |||
| a.localeCompare(b, 'en', { sensitivity: 'base' }) === 0; // https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/localeCompare | |||
There was a problem hiding this comment.
this is instead of toLowerString?
| }); | ||
|
|
||
| try { | ||
| await k8sCreate({ data: configMap, model: ConfigMapModel }); |
There was a problem hiding this comment.
should create after vm managed to create
avivtur
force-pushed
the
sysprep-volume-missing
branch
2 times, most recently
from
4effd03
to
39a101b
Compare
avivtur
force-pushed
the
sysprep-volume-missing
branch
from
39a101b
to
f77c28a
Compare
Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
avivtur
force-pushed
the
sysprep-volume-missing
branch
from
f77c28a
to
a446a4d
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avivtur, metalice, pcbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-4.16 |
|
@gouyang: new pull request created: #2005 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
📝 Description
On create VM with IT flow (quick create) the sysprep was done after the VM was created, hence it wasn't added to the VM.
🎥 Demo
After:
sysprep-volume-and-disk.mp4