Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-44838: Use VirtualMachine dynamic extension pages #2092

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

upalatucci
Copy link
Member

@upalatucci upalatucci commented Jul 22, 2024

📝 Description

Add obj as prop to be compliant with the SDK horizontal navbar that call extension components giving the obj prop

🎥 Demo

Adding test tab

Screenshot 2024-07-22 at 18 16 08

Here as you can see Overview and Test tabs are 'active'
I solved this issue

Screenshot 2024-07-22 at 18 26 47

@openshift-ci openshift-ci bot requested review from pcbailey and tnisan July 22, 2024 16:16
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Jul 22, 2024
@metalice metalice changed the title Use VirtualMachine dynamic extension pages CNV-44838: Use VirtualMachine dynamic extension pages Jul 23, 2024
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jul 23, 2024

@upalatucci: This pull request references CNV-44838 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

📝 Description

Add obj as prop to be compliant with the SDK horizontal navbar that call extension components giving the obj prop

🎥 Demo

Adding test tab

Screenshot 2024-07-22 at 18 16 08 Screenshot 2024-07-22 at 18 26 47

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@metalice
Copy link
Member

/jira-refresh

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jul 23, 2024

@upalatucci: This pull request references CNV-44838 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

📝 Description

Add obj as prop to be compliant with the SDK horizontal navbar that call extension components giving the obj prop

🎥 Demo

Adding test tab

Screenshot 2024-07-22 at 18 16 08

Here as you can see Overview and Test tabs are 'active'
I solved this issue

Screenshot 2024-07-22 at 18 26 47

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Jul 24, 2024
Copy link
Contributor

openshift-ci bot commented Jul 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [metalice,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 95dcf58 into kubevirt-ui:main Jul 24, 2024
10 checks passed
@upalatucci
Copy link
Member Author

/cherry-pick release-4.16

@openshift-cherrypick-robot
Copy link
Collaborator

@upalatucci: #2092 failed to apply on top of branch "release-4.16":

Applying: Use VirtualMachine dynamic extension pages
Using index info to reconstruct a base tree...
M	src/views/virtualmachines/details/tabs/configuration/VirtualMachineConfigurationTab.tsx
M	src/views/virtualmachines/details/tabs/snapshots/SnapshotListPage.tsx
Falling back to patching base and 3-way merge...
Auto-merging src/views/virtualmachines/details/tabs/snapshots/SnapshotListPage.tsx
Auto-merging src/views/virtualmachines/details/tabs/configuration/VirtualMachineConfigurationTab.tsx
CONFLICT (content): Merge conflict in src/views/virtualmachines/details/tabs/configuration/VirtualMachineConfigurationTab.tsx
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Use VirtualMachine dynamic extension pages
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants