Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path params replace broken #29

Closed
ClaudiuLSH opened this issue May 26, 2020 · 8 comments
Closed

Path params replace broken #29

ClaudiuLSH opened this issue May 26, 2020 · 8 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@ClaudiuLSH
Copy link

I'm trying to create a VirtualMachineInstance and I receive the following error:

2020-05-26 14:59:37,683 DEBUG https://10.43.0.1:443 "POST /apis/kubevirt.io/v1alpha3/namespaces/%7Bnamespace:%5Ba-z0-9%5D%5Ba-z0-9%5C-%5D*%7D/virtualmachineinstances HTTP/1.1" 404 246
2020-05-26 14:59:37,683 DEBUG response body: {"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"namespaces \"{namespace:[a-z0-9][a-z0-9\\\\-]*}\" not found","reason":"NotFound","details":{"name":"{namespace:[a-z0-9][a-z0-9\\-]*}","kind":"namespaces"},"code":404}

The call URL is not updated with a namespace.
According to this api_client.py line 122 the replace fails. If I update that line to '{%s:[a-z0-9][a-z0-9\\-]*}' % k, quote(str(v), safe=config.safe_chars_for_path_param)) the call works:

2020-05-26 15:01:31,731 DEBUG https://10.43.0.1:443 "POST /apis/kubevirt.io/v1alpha3/namespaces/nspt1/virtualmachineinstances HTTP/1.1" 201 1109
2020-05-26 15:01:31,732 DEBUG response body: {"apiVersion":"kubevirt.io/v1alpha3","kind":"VirtualMachineInstance","metadata":"trimmed output, too big"}
@kubevirt-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubevirt-bot kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 24, 2020
@cccs-kevin
Copy link

/remove-lifecycle stale
Can confirm, issue persists, and the suggested fix resolves it.

@kubevirt-bot kubevirt-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 21, 2020
@kubevirt-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubevirt-bot kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 20, 2020
@cccs-kevin
Copy link

/remove-lifecycle stale

@kubevirt-bot kubevirt-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 21, 2020
@kubevirt-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubevirt-bot kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 25, 2021
@kubevirt-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@kubevirt-bot kubevirt-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 24, 2021
@kubevirt-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

@kubevirt-bot
Copy link
Contributor

@kubevirt-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

3 participants