Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v1.28] Fixed typo in annotation name #1671

Merged
merged 1 commit into from
Mar 15, 2021
Merged

[release-v1.28] Fixed typo in annotation name #1671

merged 1 commit into from
Mar 15, 2021

Conversation

kubevirt-bot
Copy link
Contributor

This is an automated cherry-pick of #1665

/assign tomob

NONE

Fixed typo in annotation name
501115e 
Signed-off-by: Tomasz Baranski <tbaransk@redhat.com>
@kubevirt-bot kubevirt-bot mentioned this pull request Feb 19, 2021
Merged
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS labels Feb 19, 2021
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 73.582% when pulling 501115e on kubevirt-bot:cherry-pick-1665-to-release-v1.28 into de9eec6 on kubevirt:release-v1.28.

@tomob
Copy link
Contributor

tomob commented Feb 19, 2021

/retest

@arnongilboa
Copy link
Collaborator

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2021
@tomob
Copy link
Contributor

tomob commented Feb 22, 2021

/test pull-containerized-data-importer-e2e-k8s-1.17-ceph

1 similar comment
@awels
Copy link
Member

awels commented Feb 23, 2021

/test pull-containerized-data-importer-e2e-k8s-1.17-ceph

@tomob
Copy link
Contributor

tomob commented Feb 24, 2021

This PR depends on #1664

@awels
Copy link
Member

awels commented Feb 24, 2021

/test pull-containerized-data-importer-e2e-k8s-1.17-ceph

@tomob
Copy link
Contributor

tomob commented Feb 24, 2021

/retest

@maya-r
Copy link
Contributor

maya-r commented Mar 14, 2021

ping @awels @mhenriks @aglitke --- this PR only needs an approve status

@tomob
Copy link
Contributor

tomob commented Mar 15, 2021

/retest

@awels
Copy link
Member

awels commented Mar 15, 2021

/lgtm
/approve

@awels
Copy link
Member

awels commented Mar 15, 2021

/test pull-cdi-apidocs
/test pull-cdi-generate-verify

@kubevirt-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2021
@kubevirt-bot kubevirt-bot merged commit 4528511 into kubevirt:release-v1.28 Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awels awels Awaiting requested review from awels

@mhenriks mhenriks Awaiting requested review from mhenriks

Assignees

@tomob tomob

@awels awels

@arnongilboa arnongilboa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kubevirt-bot @coveralls @tomob @arnongilboa @awels @maya-r