Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDIStorageProfilesIncomplete should not impact operator health #3232

Conversation

arnongilboa
Copy link
Collaborator

What this PR does / why we need it:
The alert caused OpenShift Virtualization operator status go degraded.

In addition add stork-snapshot to unsupported provisioners list, as stork snapshot provisioner does not work with CDI, and shouldn't cause CDIStorageProfilesIncomplete alert.

Which issue(s) this PR fixes:
Fixes # https://issues.redhat.com/browse/CNV-39569

Special notes for your reviewer:

Release note:

BugFix: CDIStorageProfilesIncomplete should not impact operator health

The alert caused OpenShift Virtualization operator status go degraded.

Fixes CNV-39569

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
Stork snapshot provisoner does not work with CDI, and shouldn't cause
CDIStorageProfilesIncomplete alert.

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS labels May 2, 2024
@kubevirt-bot kubevirt-bot requested review from aglitke and awels May 2, 2024 09:48
Copy link
Member

@aglitke aglitke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good.

These two changes are completely unrelated. They ideally should be in separate PRs but I understand there is CI overhead to consider so not opposed to them merging as-is.

@arnongilboa
Copy link
Collaborator Author

The changes look good.

These two changes are completely unrelated. They ideally should be in separate PRs but I understand there is CI overhead to consider so not opposed to them merging as-is.

both are dealing with CDIStorageProfilesIncomplete unnecessary noises, and both fixes are originated by the same bug ;)

@awels
Copy link
Member

awels commented May 2, 2024

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2024
@arnongilboa
Copy link
Collaborator Author

/retest

@awels
Copy link
Member

awels commented May 2, 2024

/test pull-containerized-data-importer-fossa

@kubevirt-bot kubevirt-bot merged commit 630ae98 into kubevirt:main May 2, 2024
17 of 18 checks passed
@arnongilboa
Copy link
Collaborator Author

/cherrypick release-v1.59

@kubevirt-bot
Copy link
Contributor

@arnongilboa: #3232 failed to apply on top of branch "release-v1.59":

Applying: CDIStorageProfilesIncomplete should not impact operator health
Applying: Add stork-snapshot to unsupported provisioners list
Using index info to reconstruct a base tree...
M	pkg/storagecapabilities/storagecapabilities.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/storagecapabilities/storagecapabilities.go
CONFLICT (content): Merge conflict in pkg/storagecapabilities/storagecapabilities.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 Add stork-snapshot to unsupported provisioners list
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-v1.59

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

arnongilboa added a commit to arnongilboa/containerized-data-importer that referenced this pull request May 3, 2024
…or health

Manual backport of kubevirt#3232

The alert caused OpenShift Virtualization operator status go degraded.

Add unsupported provisoners that does not work with CDI and shouldn't
cause CDIStorageProfilesIncomplete alert.

Fixes CNV-41507

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
arnongilboa added a commit to arnongilboa/containerized-data-importer that referenced this pull request May 3, 2024
…or health

Manual backport of kubevirt#3232

The alert caused OpenShift Virtualization operator status go degraded.

Add unsupported provisioners that does not work with CDI and shouldn't
cause CDIStorageProfilesIncomplete alert.

Fixes CNV-41507

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
arnongilboa added a commit to arnongilboa/containerized-data-importer that referenced this pull request May 3, 2024
…or health

Manual backport of kubevirt#3232

The alert caused OpenShift Virtualization operator status go degraded.

Add unsupported provisioners that does not work with CDI and shouldn't
cause CDIStorageProfilesIncomplete alert.

Fixes CNV-41508

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
arnongilboa added a commit to arnongilboa/containerized-data-importer that referenced this pull request May 3, 2024
…or health

Manual backport of kubevirt#3232

The alert caused OpenShift Virtualization operator status go degraded.

Add unsupported provisioners that does not work with CDI and shouldn't
cause CDIStorageProfilesIncomplete alert.

Fixes CNV-39569

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
arnongilboa added a commit to arnongilboa/containerized-data-importer that referenced this pull request May 3, 2024
…or health

Manual backport of kubevirt#3232

The alert caused OpenShift Virtualization operator status go degraded.

Add unsupported provisioners that does not work with CDI and shouldn't
cause CDIStorageProfilesIncomplete alert.

Fixes CNV-41509

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
arnongilboa added a commit to arnongilboa/containerized-data-importer that referenced this pull request May 3, 2024
Manual backport of kubevirt#3232 without the operator health impact change.

Add unsupported provisioners that does not work with CDI and shouldn't
cause CDIStorageProfilesIncomplete alert.

Fixes CNV-41510

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
arnongilboa added a commit to arnongilboa/containerized-data-importer that referenced this pull request May 3, 2024
… snapshot

Manual backport of kubevirt#3232 without the operator health impact change.

Add unsupported provisioners that does not work with CDI and shouldn't
cause CDIStorageProfilesIncomplete alert.

Fixes CNV-41510

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
kubevirt-bot pushed a commit that referenced this pull request May 5, 2024
…or health (#3238)

Manual backport of #3232

The alert caused OpenShift Virtualization operator status go degraded.

Add unsupported provisioners that does not work with CDI and shouldn't
cause CDIStorageProfilesIncomplete alert.

Fixes CNV-41509

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
kubevirt-bot pushed a commit that referenced this pull request May 5, 2024
… snapshot (#3239)

Manual backport of #3232 without the operator health impact change.

Add unsupported provisioners that does not work with CDI and shouldn't
cause CDIStorageProfilesIncomplete alert.

Fixes CNV-41510

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
kubevirt-bot pushed a commit that referenced this pull request May 5, 2024
…or health (#3236)

Manual backport of #3232

The alert caused OpenShift Virtualization operator status go degraded.

Add unsupported provisioners that does not work with CDI and shouldn't
cause CDIStorageProfilesIncomplete alert.

Fixes CNV-41508

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
kubevirt-bot pushed a commit that referenced this pull request May 5, 2024
…or health (#3237)

Manual backport of #3232

The alert caused OpenShift Virtualization operator status go degraded.

Add unsupported provisioners that does not work with CDI and shouldn't
cause CDIStorageProfilesIncomplete alert.

Fixes CNV-39569

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
kubevirt-bot pushed a commit that referenced this pull request May 5, 2024
…or health (#3235)

Manual backport of #3232

The alert caused OpenShift Virtualization operator status go degraded.

Add unsupported provisioners that does not work with CDI and shouldn't
cause CDIStorageProfilesIncomplete alert.

Fixes CNV-41507

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants