-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CDIStorageProfilesIncomplete should not impact operator health #3232
CDIStorageProfilesIncomplete should not impact operator health #3232
Conversation
The alert caused OpenShift Virtualization operator status go degraded. Fixes CNV-39569 Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
Stork snapshot provisoner does not work with CDI, and shouldn't cause CDIStorageProfilesIncomplete alert. Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good.
These two changes are completely unrelated. They ideally should be in separate PRs but I understand there is CI overhead to consider so not opposed to them merging as-is.
both are dealing with CDIStorageProfilesIncomplete unnecessary noises, and both fixes are originated by the same bug ;) |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awels The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/test pull-containerized-data-importer-fossa |
/cherrypick release-v1.59 |
@arnongilboa: #3232 failed to apply on top of branch "release-v1.59":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…or health Manual backport of kubevirt#3232 The alert caused OpenShift Virtualization operator status go degraded. Add unsupported provisoners that does not work with CDI and shouldn't cause CDIStorageProfilesIncomplete alert. Fixes CNV-41507 Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
…or health Manual backport of kubevirt#3232 The alert caused OpenShift Virtualization operator status go degraded. Add unsupported provisioners that does not work with CDI and shouldn't cause CDIStorageProfilesIncomplete alert. Fixes CNV-41507 Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
…or health Manual backport of kubevirt#3232 The alert caused OpenShift Virtualization operator status go degraded. Add unsupported provisioners that does not work with CDI and shouldn't cause CDIStorageProfilesIncomplete alert. Fixes CNV-41508 Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
…or health Manual backport of kubevirt#3232 The alert caused OpenShift Virtualization operator status go degraded. Add unsupported provisioners that does not work with CDI and shouldn't cause CDIStorageProfilesIncomplete alert. Fixes CNV-39569 Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
…or health Manual backport of kubevirt#3232 The alert caused OpenShift Virtualization operator status go degraded. Add unsupported provisioners that does not work with CDI and shouldn't cause CDIStorageProfilesIncomplete alert. Fixes CNV-41509 Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
Manual backport of kubevirt#3232 without the operator health impact change. Add unsupported provisioners that does not work with CDI and shouldn't cause CDIStorageProfilesIncomplete alert. Fixes CNV-41510 Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
… snapshot Manual backport of kubevirt#3232 without the operator health impact change. Add unsupported provisioners that does not work with CDI and shouldn't cause CDIStorageProfilesIncomplete alert. Fixes CNV-41510 Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
What this PR does / why we need it:
The alert caused OpenShift Virtualization operator status go degraded.
In addition add stork-snapshot to unsupported provisioners list, as stork snapshot provisioner does not work with CDI, and shouldn't cause CDIStorageProfilesIncomplete alert.
Which issue(s) this PR fixes:
Fixes # https://issues.redhat.com/browse/CNV-39569
Special notes for your reviewer:
Release note: