Add watch for DataImportCron-labeled PVCs deletion #3285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
release-note
akalenyu
reviewed
May 22, 2024
| @@ -1077,6 +1077,17 @@ func addDataImportCronControllerWatches(mgr manager.Manager, c controller.Contro | |||
| return err | |||
| } | |||
|
|
|||
| if err := c.Watch(source.Kind(mgr.GetCache(), &corev1.PersistentVolumeClaim{}), | |||
There was a problem hiding this comment.
May want to place this above the snapshot watch, since it has a
containerized-data-importer/pkg/controller/dataimportcron-controller.go
Lines 1062 to 1063 in 4e7e683
There was a problem hiding this comment.
Good catch, fixed.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akalenyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
When the DataImportCron last import DV is manually deleted, the controller reconciles, but due to k8s default background cascading deletion, the PVC may still temporarily exist, so the controller will not re-create the DV even after the PVC is deleted, unless it reconciles due to other watched CR like DataSource. In the scenario of CNV-39688, since we move from pvc source format to snapshot, the DataSource won’t update until a snapshot is created, which will never happen. To solve it we add a watch for deletion of DataImportCron-labeled PVCs. The change was tested locally, but since it required two storage classes it’s currently out of scope for the existing CI lanes, so it requires tier-2 test. Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
arnongilboa
force-pushed
the
watch_dic_pvcs_deletion
branch
from
4e7e683
to
42135a7
Compare
|
/retest |
1 similar comment
|
/retest |
|
/cherrypick release-v1.59 |
|
@arnongilboa: new pull request created: #3300 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick release-v1.58 |
|
@arnongilboa: #3285 failed to apply on top of branch "release-v1.58": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
arnongilboa
added a commit
to arnongilboa/containerized-data-importer
that referenced
this pull request
Jun 2, 2024
Manual backport of kubevirt#3285 When the DataImportCron last import DV is manually deleted, the controller reconciles, but due to k8s default background cascading deletion, the PVC may still temporarily exist, so the controller will not re-create the DV even after the PVC is deleted, unless it reconciles due to other watched CR like DataSource. In the scenario of CNV-39688, since we move from pvc source format to snapshot, the DataSource won’t update until a snapshot is created, which will never happen. To solve it we add a watch for deletion of DataImportCron-labeled PVCs. The change was tested locally, but since it required two storage classes it’s currently out of scope for the existing CI lanes, so it requires tier-2 test. Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
arnongilboa
added a commit
to arnongilboa/containerized-data-importer
that referenced
this pull request
Jun 2, 2024
Manual backport of kubevirt#3285 When the DataImportCron last import DV is manually deleted, the controller reconciles, but due to k8s default background cascading deletion, the PVC may still temporarily exist, so the controller will not re-create the DV even after the PVC is deleted, unless it reconciles due to other watched CR like DataSource. In the scenario of CNV-39688, since we move from pvc source format to snapshot, the DataSource won’t update until a snapshot is created, which will never happen. To solve it we add a watch for deletion of DataImportCron-labeled PVCs. The change was tested locally, but since it required two storage classes it’s currently out of scope for the existing CI lanes, so it requires tier-2 test. Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
kubevirt-bot
pushed a commit
that referenced
this pull request
Jun 2, 2024
…3301) Manual backport of #3285 When the DataImportCron last import DV is manually deleted, the controller reconciles, but due to k8s default background cascading deletion, the PVC may still temporarily exist, so the controller will not re-create the DV even after the PVC is deleted, unless it reconciles due to other watched CR like DataSource. In the scenario of CNV-39688, since we move from pvc source format to snapshot, the DataSource won’t update until a snapshot is created, which will never happen. To solve it we add a watch for deletion of DataImportCron-labeled PVCs. The change was tested locally, but since it required two storage classes it’s currently out of scope for the existing CI lanes, so it requires tier-2 test. Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
kubevirt-bot
pushed a commit
that referenced
this pull request
Jun 2, 2024
…3302) Manual backport of #3285 When the DataImportCron last import DV is manually deleted, the controller reconciles, but due to k8s default background cascading deletion, the PVC may still temporarily exist, so the controller will not re-create the DV even after the PVC is deleted, unless it reconciles due to other watched CR like DataSource. In the scenario of CNV-39688, since we move from pvc source format to snapshot, the DataSource won’t update until a snapshot is created, which will never happen. To solve it we add a watch for deletion of DataImportCron-labeled PVCs. The change was tested locally, but since it required two storage classes it’s currently out of scope for the existing CI lanes, so it requires tier-2 test. Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When the
DataImportCronlast importDVis manually deleted, the controller reconciles, but due to k8s default background cascading deletion, thePVCmay still temporarily exist, so the controller will not re-create theDVeven after thePVCis deleted, unless it reconciles due to other watched CR likeDataSource. In the scenario of CNV-39688, since we move fromPVCsource format to snapshot, theDataSourcewon’t update until a snapshot is created, which will never happen. To solve it we add a watch for deletion of DataImportCron-labeledPVCs. The change was tested locally, but since it required two storage classes it’s currently out of scope for the existing CI lanes, so it requires tier-2 test.Which issue(s) this PR fixes:
Fixes # https://issues.redhat.com/browse/CNV-39688
Special notes for your reviewer:
Release note: