Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mutating webhook registration broken #894

Merged
merged 1 commit into from
Jul 30, 2019

Conversation

mhenriks
Copy link
Member

What this PR does / why we need it:

Copy/paste error, was using the validating webhook name for the mutating webhook registration

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

We should backport this.

Release note:

NONE

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L labels Jul 28, 2019
@mhenriks
Copy link
Member Author

ci test please

Copy link
Member

@awels awels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@awels awels merged commit e85a66c into kubevirt:master Jul 30, 2019
awels pushed a commit to awels/containerized-data-importer that referenced this pull request Aug 19, 2019
awels pushed a commit that referenced this pull request Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants