Improving the static version of KubeVirt to an autodiscovery of the l… #130
Conversation
…ast version to avoid updates on the README each time a new KubeVirt version is released Signed-off-by: Pedro Ibáñez <pedro@redhat.com>
kubevirt-bot
added
the
dco-signoff: yes
README.md
Outdated
| @@ -58,11 +58,12 @@ $ minikube ssh -- test -e /dev/kvm \ | |||
| Now you are finally ready to deploy KubeVirt using our operator (comparable to an installer): | |||
|
|
|||
| ```bash | |||
| $ kubectl apply -f https://github.com/kubevirt/kubevirt/releases/download/v0.24.0/kubevirt-operator.yaml | |||
| $ export KUBEVIRT_LAST_VERSION=$(curl -s https://api.github.com/repos/kubevirt/kubevirt/releases/latest | jq -r .tag_name) | |||
There was a problem hiding this comment.
This logic sadly does not work, as GH does not do semver based last, but only time based last
There was a problem hiding this comment.
export KUBEVIRT_VERSION=$(curl -s https://api.github.com/repos/kubevirt/kubevirt/releases|grep tag_name|sort -V | tail -1 | awk -F':' '{print $2}' | sed 's/,//' | xargs | cut -d'-' -f1)
That's how we do it at Quickstart, sort -V takes care of semver sorting
There was a problem hiding this comment.
Yes. I had that in the past as well, but went back to static version numbres to make copy and pasting easy and less error prone
There was a problem hiding this comment.
The static version is a pain as somebody has to update the README every time there is a release, is that what you prefer to have?
There was a problem hiding this comment.
@fabiand how would you like to have it? static version or automatic version?
|
I'd like to stick to explicit versions in the demo.
Simplicity over diifficult to read.
The other option is to revive the thread about maintaining an repo to point
to the latest version of certain "channels". There was a thread on
kubevirt-dev on this
|
…ic version to v0.25.0 Signed-off-by: Pedro Ibáñez <pedro@redhat.com>
Then, it's done! roll-backed the magic, the static is back updated to v0.25.0. |
|
@fabiand it can be merge, right? lgtm & approve welcomes :) |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iranzo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
Improving the static version of KubeVirt to an autodiscovery way to avoid updates on the README.md each time a new KubeVirt version is released.
Signed-off-by: Pedro Ibáñez pedro@redhat.com