Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump golang and its dependencies #2948

Merged
merged 1 commit into from
May 10, 2024
Merged

Bump golang and its dependencies #2948

merged 1 commit into from
May 10, 2024

Conversation

tiraboschi
Copy link
Member

@tiraboschi tiraboschi commented May 7, 2024 •
edited
Loading

What this PR does / why we need it:
Bump golang dependencies

  • golang 1.21 => 1.22
  • github.com/kubevirt/monitoring/pkg/metrics/parser v0.0.0-20240408121652-bb3835ce94d8 => v0.0.0-20240505100225-e29dee0bb12b
  • github.com/machadovilaca/operator-observability v0.0.19 => v0.0.20
  • github.com/onsi/ginkgo/v2 v2.17.1 => v2.17.2
  • github.com/onsi/gomega v1.32.0 => v1.33.1
  • github.com/openshift/library-go v0.0.0-20240410140155-0045765c004e => v0.0.0-20240506162756-6301addeda88
  • github.com/operator-framework/api v0.23.0 => v0.24.0
  • github.com/operator-framework/operator-lib v0.12.0 => v0.13.0
  • github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring v0.73.0 => v0.73.2
  • golang.org/x/tools v0.20.0 => v0.21.0
  • k8s.io/* v0.29.3 => v0.30.0
  • k8s.io/kube-openapi v0.0.0-20240403164606-bc84c2ddaf99 => v0.0.0-20240430033511-f0e62f92d13f
  • k8s.io/utils v0.0.0-20240310230437-4693a0247e57 => v0.0.0-20240502163921-fe8a2dddb1d0
  • sigs.k8s.io/controller-runtime v0.17.3 => v0.18.2
  • sigs.k8s.io/controller-tools v0.14.0 => v0.15.0

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

  • PR Message
  • Commit Messages
  • How to test
  • Unit Tests
  • Functional Tests
  • User Documentation
  • Developer Documentation
  • Upgrade Scenario
  • Uninstallation Scenario
  • Backward Compatibility
  • Troubleshooting Friendly

Jira Ticket:

NONE

Release note:

Bump to controller-runtime v0.18.2 and k8s.io/* v0.30.0

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 7, 2024
@tiraboschi tiraboschi changed the title Bump golang dependencies WIP: Bump golang and its dependencies May 7, 2024
@kubevirt-bot kubevirt-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 7, 2024
@tiraboschi
Copy link
Member Author

/retest

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 8, 2024
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 8, 2024
@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented May 8, 2024 •
edited
Loading

@tiraboschi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-hyperconverged-cluster-operator-e2e-k8s-1.28 be8c347 link true /test pull-hyperconverged-cluster-operator-e2e-k8s-1.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tiraboschi
WIP: Bump golang and its dependencies
44b76b7 
- golang 1.21 => 1.22
- github.com/kubevirt/monitoring/pkg/metrics/parser v0.0.0-20240408121652-bb3835ce94d8 => v0.0.0-20240505100225-e29dee0bb12b
- github.com/machadovilaca/operator-observability v0.0.19 => v0.0.20
- github.com/onsi/ginkgo/v2 v2.17.1 => v2.17.2
- github.com/onsi/gomega v1.32.0 => v1.33.1
- github.com/openshift/library-go v0.0.0-20240410140155-0045765c004e => v0.0.0-20240506162756-6301addeda88
- github.com/operator-framework/api v0.23.0 => v0.24.0
- github.com/operator-framework/operator-lib v0.12.0 => v0.13.0
- github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring v0.73.0 => v0.73.2
- golang.org/x/tools v0.20.0 => v0.21.0
- k8s.io/* v0.29.3 => v0.30.0
- k8s.io/kube-openapi v0.0.0-20240403164606-bc84c2ddaf99 => v0.0.0-20240430033511-f0e62f92d13f
- k8s.io/utils v0.0.0-20240310230437-4693a0247e57 => v0.0.0-20240502163921-fe8a2dddb1d0
- sigs.k8s.io/controller-runtime v0.17.3 => v0.18.2
- sigs.k8s.io/controller-tools v0.14.0 => v0.15.0

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tiraboschi
Copy link
Member Author

/retest

2 similar comments
@tiraboschi
Copy link
Member Author

/retest

@tiraboschi
Copy link
Member Author

/retest

@nunnatsa
Copy link
Collaborator

nit: 1.22.3 released with some security fixes to the go command and the net package.

Other than that
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2024
@tiraboschi
Copy link
Member Author

/retest

@tiraboschi tiraboschi changed the title WIP: Bump golang and its dependencies Bump golang and its dependencies May 10, 2024
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 10, 2024
@tiraboschi
Copy link
Member Author

nit: 1.22.3 released with some security fixes to the go command and the net package.

let's keep this for a separate PR

@nunnatsa
Copy link
Collaborator

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2024
@kubevirt-bot kubevirt-bot merged commit 18418bb into kubevirt:main May 10, 2024
32 checks passed
@tiraboschi tiraboschi deleted the bump_k8s_v0.30.0 branch May 10, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunnatsa nunnatsa Awaiting requested review from nunnatsa

@orenc1 orenc1 Awaiting requested review from orenc1

Assignees

@nunnatsa nunnatsa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tiraboschi @kubevirt-bot @nunnatsa