This change will introduced a dedicated playbook for the apb. #283
Conversation
A number of issues were raised around the playbooks executing on `hosts: localhost` where they should be run on an oc/k8s master node. However that breaks the apb[0]. This change will add a dedicated apb playbook. [0]: https://github.com/ansibleplaybookbundle/kubevirt-apb/blob/b471ef705517b96cb02254451b4dde923e062e56/playbooks/provision.yml#L10
playbooks/apb-kubevirt.yml
Outdated
| roles: | ||
| - role: kubevirt | ||
|
|
||
| - import_playbook: "{{ playbook_dir }}/storage.yml" |
There was a problem hiding this comment.
I believe the storage is being dropped off. @rthallisey am I right ?
|
@dcritch all the places that are set to local host can be changed to master/node ect. because the apb has it's own inventory that sets the equivalent inventory to localhost. |
|
@rthallisey so this PR isn't necessary? It would be better not to have to maintain a separate playbook, but I thought it was causing issues e.g. #268 |
|
@davidvossel I think the PR isn't necessary because the apb is setup to handle all current 'hosts' in the inventory file. The reason issue #268 occurred was the inventory file not being picked up by the start script in the apb-base layer. I fixed that here ansibleplaybookbundle/apb-base#31 |
was this meant for @dcritch ? |
|
sorry @davidvossel, yes @dcritch. |
|
Got it. Thanks! |
A number of issues were raised around the playbooks executing on
hosts: localhostwhere they should be run on an oc/k8s master node.However that breaks the ansible playbook bundle 0. This change will add a dedicated playbook
for the apb.