Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v0.15] fix: change the condition to consider a DV import failed #266

Closed
wants to merge 1 commit into from
Closed

[release-v0.15] fix: change the condition to consider a DV import failed #266

wants to merge 1 commit into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #262

/assign ksimon1

NONE

@jcanocan
fix: change the condition to consider a DV import failed
2fdd08e 
The test `TaskRun fails and DataVolume is modified but does not import
successfully` checks if a DV has failed by asserting several fields
on the DV. One of them is `conditions[cdiv1beta1.DataVolumeBound].Status
== v1.ConditionTrue`. In the current version of CDI, if a DV fails to
fetch the import link, which is the scenario in this test, the
underlining PVC is not bound. Therefore, the test assertion fails even
if the DV has failed to import.
Since the test already has a sufficient amount of assertions to check if
a DV import failed, it drops the check
`conditions[cdiv1beta1.DataVolumeBound].Status == v1.ConditionTrue`.

Signed-off-by: Javier Cano Cano <jcanocan@redhat.com>
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Oct 2, 2023
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 2, 2023
Merged
@openshift-ci openshift-ci bot requested review from 0xFelix and ksimon1 October 2, 2023 07:30
@openshift-ci
Copy link

openshift-ci bot commented Oct 2, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign ksimon1 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Oct 2, 2023

Hi @openshift-cherrypick-robot. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 2, 2023
@ksimon1 ksimon1 closed this Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFelix 0xFelix Awaiting requested review from 0xFelix

@ksimon1 ksimon1 Awaiting requested review from ksimon1

Assignees

@ksimon1 ksimon1

Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@openshift-cherrypick-robot @kubevirt-bot @ksimon1 @jcanocan