Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump velero to 1.9.2 #84

Closed
wants to merge 6 commits into from
Closed

Bump velero to 1.9.2 #84

wants to merge 6 commits into from

Conversation

brybacki
Copy link
Contributor

What this PR does / why we need it:

Bump velero to 1.9.2

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

@kubevirt-bot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Sep 29, 2022
@brybacki brybacki marked this pull request as ready for review September 29, 2022 13:00
@kubevirt-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from brybacki by writing /assign @brybacki in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 29, 2022
@brybacki
Copy link
Contributor Author

/test pull-kvp-functional-test
testin again to see if failures are repeatable

@brybacki
Copy link
Contributor Author

/test pull-kvp-functional-test

@brybacki
Bump velero to 1.9.2
60f1674 
Signed-off-by: Bartosz Rybacki <brybacki@redhat.com>
@brybacki
Copy link
Contributor Author

The fail in the tests is probably this one:
vmware-tanzu/velero#5400

Rebased to get updated test config, whithout snapshot location. Should now work.

@brybacki
Correctly configure KUBEVIRT vars
e128e46 
Signed-off-by: Bartosz Rybacki <brybacki@redhat.com>
@brybacki
Copy link
Contributor Author

The same 3 tests fail, now with different error, investigating
It works ok, in my local env.

@brybacki
Copy link
Contributor Author 

ime="2022-10-13T09:53:53Z" level=info msg="Backed up a total of 2 items" backup=velero/test-backup-1665654791385176114 logSource="pkg/backup/backup.go:405" progress=
2022/10/13 09:53:53  info Waiting for CSI driver to reconcile volumesnapshot kvp-e2e-tests-c7c5q/velero-test-dv-775lr. Retrying in 5s
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x19c6f6d]

goroutine 3607 [running]:
github.com/vmware-tanzu/velero/pkg/controller.(*backupController).deleteVolumeSnapshot.func1(0xc000465680)
	/go/src/github.com/vmware-tanzu/velero/pkg/controller/backup_controller.go:940 +0xad
created by github.com/vmware-tanzu/velero/pkg/controller.(*backupController).deleteVolumeSnapshot
	/go/src/github.com/vmware-tanzu/velero/pkg/controller/backup_controller.go:936 +0xf7

@brybacki
Copy link
Contributor Author

I can confirm that the 3 tests only include PVC or VM and thus exclude VolumeSnapshots, VolumeSnapshotContents etc.
Previously on velero 1.8 it worked, now it failes with panic or some other similar error inside velero.

So it is exactly the problem described in vmware-tanzu/velero#5400

@brybacki
Copy link
Contributor Author 

time="2022-10-13T10:12:06Z" level=error msg="Not find %!s(*string=0xc00180eda0) from the vscMap" backup=velero/test-backup-1665655891460820519 logSource="pkg/controller/backup_controller.go:944"

@brybacki brybacki mentioned this pull request Oct 17, 2022
Closed
@brybacki
Remove newlines from logs
9540b25 
Signed-off-by: Bartosz Rybacki <brybacki@redhat.com>
@brybacki
Log volumeSnapshot on failure
af8a0f1 
Signed-off-by: Bartosz Rybacki <brybacki@redhat.com>
@brybacki
Update test for include backup
85f7f19 
Temporarily added volumesnapshot and volumesnapshotcontent to backup, so new
velero 1.9 can be used. This has to be reviewed when newer velero is available.

Signed-off-by: Bartosz Rybacki <brybacki@redhat.com>
@brybacki
Copy link
Contributor Author

/test pull-kvp-functional-test

@brybacki
Limit backup to single namespace
609a12f 
Signed-off-by: Bartosz Rybacki <brybacki@redhat.com>
@brybacki
Copy link
Contributor Author

/hold

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 20, 2022
@brybacki
Copy link
Contributor Author

Closing this PR, we can wait for a velero-1.9.3 with fixes to null handling for volumesnapshots

Some cleanup commits cherry picket to a new PR: #99

@brybacki brybacki closed this Oct 21, 2022
@ShellyKa13 ShellyKa13 mentioned this pull request Oct 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maya-r maya-r Awaiting requested review from maya-r

@mhenriks mhenriks Awaiting requested review from mhenriks

@awels awels Awaiting requested review from awels

Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brybacki @kubevirt-bot