-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.2] ctrl: fix MaxSockets calculation #12073
Conversation
667810b
to
585e826
Compare
585e826
to
af1f710
Compare
Kubevirt test_id:6867 is currently broken, it will be fixed with kubevirt/kubevirt#12073 It's not a blocker/critical issue so we can temporarely tolerate it. The test will be enabled back when we will be able to consume a newer and fixed Kubevirt release. Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
Kubevirt test_id:6867 is currently broken, it will be fixed with kubevirt/kubevirt#12073 It's not a blocker/critical issue so we can temporarely tolerate it. The test will be enabled back when we will be able to consume a newer and fixed Kubevirt release. Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
af1f710
to
898f9ac
Compare
/test pull-kubevirt-unit-test |
898f9ac
to
6c9bcc2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
/hold |
* Enable VM live update rollout strategy always Signed-off-by: Jed Lejosne <jed@redhat.com> * Skip test test_id:6867 Kubevirt test_id:6867 is currently broken, it will be fixed with kubevirt/kubevirt#12073 It's not a blocker/critical issue so we can temporarely tolerate it. The test will be enabled back when we will be able to consume a newer and fixed Kubevirt release. Signed-off-by: Simone Tiraboschi <stirabos@redhat.com> --------- Signed-off-by: Jed Lejosne <jed@redhat.com> Signed-off-by: Simone Tiraboschi <stirabos@redhat.com> Co-authored-by: Simone Tiraboschi <stirabos@redhat.com>
6c9bcc2
to
c990e96
Compare
c990e96
to
395b90b
Compare
/approve |
395b90b
to
d00f106
Compare
* [release-1.2] Enable VM live update rollout strategy always Signed-off-by: Jed Lejosne <jed@redhat.com> * Skip test test_id:6867 Kubevirt test_id:6867 is currently broken, it will be fixed with kubevirt/kubevirt#12073 It's not a blocker/critical issue so we can temporarely tolerate it. The test will be enabled back when we will be able to consume a newer and fixed Kubevirt release. Signed-off-by: Simone Tiraboschi <stirabos@redhat.com> --------- Signed-off-by: Jed Lejosne <jed@redhat.com> Signed-off-by: Simone Tiraboschi <stirabos@redhat.com> Co-authored-by: Jed Lejosne <jed@redhat.com>
d00f106
to
62ac1d9
Compare
This patch fixes the test test_id:6867 when LiveUpdate is used as a rollout-strategy. https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/kubevirt_hyperconverged-cluster-operator/2846/pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-kv-smoke-gcp/1798844855967813632 MaxSockets was not considering CPU requests, this fixes it. Signed-off-by: Antonio Cardace <acardace@redhat.com>
62ac1d9
to
41fa333
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jean-edouard The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jean-edouard @fossedihelm this fix is specific because the code in main has changed and diverges now (main is fixed). |
@acardace: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/retest-required |
This patch fixes the test test_id:6867 when LiveUpdate is used as a rollout-strategy.
https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/kubevirt_hyperconverged-cluster-operator/2846/pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-kv-smoke-gcp/1798844855967813632
MaxSockets was not considering CPU requests, this fixes it.
What this PR does
Before this PR:
Test 'test_id:6867' fails with LiveUpdate as rollout-strategy.
After this PR:
Test 'test_id:6867' passes with LiveUpdate as rollout-strategy.
Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note