Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.2] ctrl: fix MaxSockets calculation #12073

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

acardace
Copy link
Member

@acardace acardace commented Jun 7, 2024

This patch fixes the test test_id:6867 when LiveUpdate is used as a rollout-strategy.
https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/kubevirt_hyperconverged-cluster-operator/2846/pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-kv-smoke-gcp/1798844855967813632

MaxSockets was not considering CPU requests, this fixes it.

What this PR does

Before this PR:
Test 'test_id:6867' fails with LiveUpdate as rollout-strategy.

After this PR:

Test 'test_id:6867' passes with LiveUpdate as rollout-strategy.

Fixes #

Why we need it and why it was done in this way

The following tradeoffs were made:

The following alternatives were considered:

Links to places where the discussion took place:

Special notes for your reviewer

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note

NONE

@kubevirt-bot kubevirt-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 7, 2024
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Jun 7, 2024
@kubevirt-bot kubevirt-bot added size/M and removed size/S labels Jun 7, 2024
tiraboschi added a commit to jean-edouard/hyperconverged-cluster-operator that referenced this pull request Jun 7, 2024
Kubevirt test_id:6867 is currently broken,
it will be fixed with kubevirt/kubevirt#12073
It's not a blocker/critical issue so we can temporarely tolerate it.
The test will be enabled back when we will be able to consume a
newer and fixed Kubevirt release.

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
tiraboschi added a commit to tiraboschi/hyperconverged-cluster-operator that referenced this pull request Jun 7, 2024
Kubevirt test_id:6867 is currently broken,
it will be fixed with kubevirt/kubevirt#12073
It's not a blocker/critical issue so we can temporarely tolerate it.
The test will be enabled back when we will be able to consume a
newer and fixed Kubevirt release.

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
@acardace
Copy link
Member Author

acardace commented Jun 7, 2024

/test pull-kubevirt-unit-test

Copy link
Contributor

@fossedihelm fossedihelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2024
@acardace
Copy link
Member Author

acardace commented Jun 7, 2024

/hold
the issue might lie somewhere else, still investigating

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 7, 2024
kubevirt-bot pushed a commit to kubevirt/hyperconverged-cluster-operator that referenced this pull request Jun 7, 2024
* Enable VM live update rollout strategy always

Signed-off-by: Jed Lejosne <jed@redhat.com>

* Skip test test_id:6867

Kubevirt test_id:6867 is currently broken,
it will be fixed with kubevirt/kubevirt#12073
It's not a blocker/critical issue so we can temporarely tolerate it.
The test will be enabled back when we will be able to consume a
newer and fixed Kubevirt release.

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>

---------

Signed-off-by: Jed Lejosne <jed@redhat.com>
Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
Co-authored-by: Simone Tiraboschi <stirabos@redhat.com>
@kubevirt-bot kubevirt-bot added size/S and removed lgtm Indicates that a PR is ready to be merged. size/M labels Jun 7, 2024
@acardace acardace changed the title ctrl: remove CPU hotplug validation in VMI webhook ctrl: fix MaxSockets calculation Jun 7, 2024
@jean-edouard
Copy link
Contributor

/approve
/hold cancel

@kubevirt-bot kubevirt-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 7, 2024
@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 7, 2024
kubevirt-bot pushed a commit to kubevirt/hyperconverged-cluster-operator that referenced this pull request Jun 8, 2024
* [release-1.2] Enable VM live update rollout strategy always

Signed-off-by: Jed Lejosne <jed@redhat.com>

* Skip test test_id:6867

Kubevirt test_id:6867 is currently broken,
it will be fixed with kubevirt/kubevirt#12073
It's not a blocker/critical issue so we can temporarely tolerate it.
The test will be enabled back when we will be able to consume a
newer and fixed Kubevirt release.

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>

---------

Signed-off-by: Jed Lejosne <jed@redhat.com>
Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
Co-authored-by: Jed Lejosne <jed@redhat.com>
@kubevirt-bot kubevirt-bot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. and removed dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jun 10, 2024
@acardace acardace changed the base branch from main to release-1.2 June 10, 2024 08:36
@acardace acardace changed the title ctrl: fix MaxSockets calculation [release-1.2] ctrl: fix MaxSockets calculation Jun 10, 2024
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 10, 2024
This patch fixes the test test_id:6867 when LiveUpdate is used as a rollout-strategy.
https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/kubevirt_hyperconverged-cluster-operator/2846/pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-e2e-kv-smoke-gcp/1798844855967813632

MaxSockets was not considering CPU requests, this fixes it.

Signed-off-by: Antonio Cardace <acardace@redhat.com>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Jun 10, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jean-edouard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@acardace
Copy link
Member Author

acardace commented Jun 10, 2024

@jean-edouard @fossedihelm this fix is specific because the code in main has changed and diverges now (main is fixed).

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2024
@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented Jun 10, 2024

@acardace: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubevirt-verify-rpms 62ac1d9 link false /test pull-kubevirt-verify-rpms
pull-kubevirt-goveralls 62ac1d9 link false /test pull-kubevirt-goveralls
pull-kubevirt-fossa 62ac1d9 link true /test pull-kubevirt-fossa
pull-kubevirt-metrics-lint 62ac1d9 link false /test pull-kubevirt-metrics-lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-bot kubevirt-bot merged commit 367182a into kubevirt:release-1.2 Jun 11, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants