Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GC note to DataVolumeSource api doc #8726

Merged
merged 1 commit into from
Nov 10, 2022
Merged

Add GC note to DataVolumeSource api doc #8726

merged 1 commit into from
Nov 10, 2022

Conversation

arnongilboa
Copy link
Contributor

Signed-off-by: Arnon Gilboa agilboa@redhat.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS labels Nov 7, 2022
@kubevirt-bot kubevirt-bot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Nov 7, 2022
@arnongilboa
Copy link
Contributor Author

FYI @dominikholler

@dominikholler
Copy link

@arnongilboa thanks for the PR!

@dominikholler
Copy link

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2022
0xFelix
0xFelix reviewed Nov 7, 2022
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to run make generate.

@arnongilboa
Add GC note to DataVolumeSource api doc
06e62dd 
Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
@kubevirt-bot kubevirt-bot added size/M and removed lgtm Indicates that a PR is ready to be merged. size/XS labels Nov 7, 2022
0xFelix
0xFelix approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@0xFelix 0xFelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2022
@arnongilboa
Copy link
Contributor Author

/assign @stu-gott

xpivarc
xpivarc reviewed Nov 8, 2022
View reviewed changes
Copy link
Member

@xpivarc xpivarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xpivarc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2022
@arnongilboa
Copy link
Contributor Author

/retest

@brianmcarey
Copy link
Member

/retest-required

@arnongilboa
Copy link
Contributor Author

/test pull-kubevirt-e2e-k8s-1.24-sig-network-root

@arnongilboa
Copy link
Contributor Author

/test pull-kubevirt-e2e-k8s-1.23-sig-storage

@maya-r
Copy link
Contributor

maya-r commented Nov 10, 2022

/retest-required

@kubevirt-bot kubevirt-bot merged commit 24ec5ba into kubevirt:main Nov 10, 2022
@arnongilboa
Copy link
Contributor Author

/cherry-pick release-0.58

@kubevirt-bot kubevirt-bot mentioned this pull request Nov 10, 2022
Merged
@kubevirt-bot
Copy link
Contributor

@arnongilboa: new pull request created: #8761

In response to this:

/cherry-pick release-0.58

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xpivarc xpivarc xpivarc left review comments

@0xFelix 0xFelix 0xFelix approved these changes

@marceloamaral marceloamaral Awaiting requested review from marceloamaral

Assignees

@0xFelix 0xFelix

@dominikholler dominikholler

@stu-gott stu-gott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@arnongilboa @dominikholler @kubevirt-bot @brianmcarey @maya-r @0xFelix @xpivarc @stu-gott