Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.59] Fix addvolume removevolume bugs #9197

Merged
merged 3 commits into from
Feb 15, 2023
Merged

[release-0.59] Fix addvolume removevolume bugs #9197

merged 3 commits into from
Feb 15, 2023

Commits on Feb 8, 2023

  1. Fix add/remove volume bugs 

    * Fix bug of allowing to add existing volume pvc/dv
with another volume name: the code checked for volume.Name
instead of checking the dv/pvc name.
* Fix bug of allowing to remove existing volume which wasnt
hotplugged.
* Add the check of add and remove volume to persistent add/remove
volume code path - in case of add/remove to VM the checks should also
happen.
* Add and fix current UT accordingly.

Signed-off-by: Shelly Kagan <skagan@redhat.com>
    @ShellyKa13
    ShellyKa13 authored and kubevirt-bot committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    cc67f64 View commit details
    Browse the repository at this point in the history

  2. Add negative functional test to verify bug fix 

    Signed-off-by: Shelly Kagan <skagan@redhat.com>
    @ShellyKa13
    ShellyKa13 authored and kubevirt-bot committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    b48aa3d View commit details
    Browse the repository at this point in the history

  3. Adress review and failing tests 

    Signed-off-by: Shelly Kagan <skagan@redhat.com>
    @ShellyKa13
    ShellyKa13 authored and kubevirt-bot committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    6174c0e View commit details
    Browse the repository at this point in the history