Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kind-ovn: Fix cluster-down function #1196

Merged
merged 1 commit into from
May 27, 2024
Merged

Conversation

oshoval
Copy link
Contributor

@oshoval oshoval commented May 27, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:


@kubevirt-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 27, 2024
Signed-off-by: Or Shoval <oshoval@redhat.com>
@oshoval oshoval changed the title WIP kind-ovn: Fix cluster-down function May 27, 2024
@oshoval oshoval marked this pull request as ready for review May 27, 2024 13:24
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 27, 2024
@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2024
@qinqon
Copy link
Contributor

qinqon commented May 27, 2024

/lgtm
/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2024
@kubevirt-bot kubevirt-bot merged commit 603150b into kubevirt:main May 27, 2024
7 of 9 checks passed
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request May 28, 2024
[603150b kind-ovn: Fix cluster-down function](kubevirt/kubevirtci#1196)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <kubevirtbot@redhat.com>
alicefr pushed a commit to alicefr/kubevirt that referenced this pull request Jun 5, 2024
[603150b kind-ovn: Fix cluster-down function](kubevirt/kubevirtci#1196)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <kubevirtbot@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants