Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing whitespace in check script #1216

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Fix missing whitespace in check script #1216

merged 1 commit into from
Jul 11, 2024

Conversation

Davo911
Copy link
Contributor

@Davo911 Davo911 commented Jul 8, 2024

What this PR does / why we need it:
cluster-up/check.sh fails, as the whitespace is missing in an if condition

Release note:

NONE

@kubevirt-bot kubevirt-bot added the dco-signoff: no Indicates the PR's author has not DCO signed all their commits. label Jul 8, 2024
@kubevirt-bot
Copy link
Contributor

Hi @Davo911. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Davo911
fix missing whitespace
b098f41 
Signed-off-by: Thomas-David Griedel <griedel911@gmail.com>
@Davo911 Davo911 force-pushed the fix-condition-whitespace-in-check branch from 9c5e20e to b098f41 Compare July 8, 2024 21:15
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Jul 8, 2024
@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2024
@xpivarc
Copy link
Member

xpivarc commented Jul 11, 2024

/cc @dhiller @brianmcarey

brianmcarey
brianmcarey approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@brianmcarey brianmcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianmcarey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2024
@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented Jul 11, 2024 •
edited
Loading

@Davo911: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
check-up-kind-1.27-vgpu b098f41 link false /test check-up-kind-1.27-vgpu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kubevirt-commenter-bot
Copy link

/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubevirt-bot kubevirt-bot merged commit c43f010 into kubevirt:main Jul 11, 2024
9 of 10 checks passed
@Davo911 Davo911 deleted the fix-condition-whitespace-in-check branch July 11, 2024 15:45
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Jul 17, 2024
@kubevirt-bot
Bump kubevirtci
f6bc76b 
[a087e7e Automatic bump of CentOS Stream to latest](kubevirt/kubevirtci#1219)
[83e15cc alpine,image: Use full image name for qemu-user-static image](kubevirt/kubevirtci#1218)
[aa7d876 Library based ssh](kubevirt/kubevirtci#1209)
[c43f010 fix missing whitespace](kubevirt/kubevirtci#1216)
[9bb50bf enable vm-image-builder for s390x.](kubevirt/kubevirtci#1207)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <kubevirtbot@redhat.com>
@kubevirt-bot kubevirt-bot mentioned this pull request Jul 17, 2024
Merged
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Jul 18, 2024
@kubevirt-bot
Bump kubevirtci
7eacd37 
[f3a5054 fix: Run etcd commads with sudo](kubevirt/kubevirtci#1223)
[a087e7e Automatic bump of CentOS Stream to latest](kubevirt/kubevirtci#1219)
[83e15cc alpine,image: Use full image name for qemu-user-static image](kubevirt/kubevirtci#1218)
[aa7d876 Library based ssh](kubevirt/kubevirtci#1209)
[c43f010 fix missing whitespace](kubevirt/kubevirtci#1216)
[9bb50bf enable vm-image-builder for s390x.](kubevirt/kubevirtci#1207)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <kubevirtbot@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianmcarey brianmcarey brianmcarey approved these changes

@xpivarc xpivarc xpivarc approved these changes

@oshoval oshoval Awaiting requested review from oshoval

@rmohr rmohr Awaiting requested review from rmohr

@dhiller dhiller Awaiting requested review from dhiller

Assignees

@brianmcarey brianmcarey

@xpivarc xpivarc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Davo911 @kubevirt-bot @xpivarc @kubevirt-commenter-bot @brianmcarey