Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy SSPDown runbook to a correct runbook file name #165

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

assafad
Copy link
Collaborator

@assafad assafad commented Mar 19, 2023

Currently, SSPDown alert has a runbook URL with the name SSPOperatorDown (http://kubevirt.io/monitoring/runbooks/SSPOperatorDown.html).

This PR copies this wrong named runbook to a new correct runbook, and links the correct one from the wrong one.

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Mar 19, 2023
@assafad assafad changed the title Copy SSPDown runbook to a correct file name Copy SSPDown runbook to a correct runbook file name Mar 19, 2023
@@ -0,0 +1,50 @@
# SSPDown
<!-- Edited by apinnick, Nov. 2022-->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this comment

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@apinnick
Copy link
Collaborator

/lgtm

Signed-off-by: assafad <aadmi@redhat.com>
@sradco sradco merged commit e279405 into kubevirt:main Mar 20, 2023
@machadovilaca
Copy link
Member

@sradco @assafad sanity was failing because you forgot to reindex the runbooks. Fixed in #167

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants