Bump shellcheck to v0.10.0 #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
release-note-none
openshift-ci
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tiraboschi
force-pushed
the
bump_shellcheck
branch
from
a9175a3
to
26e75e7
Compare
tiraboschi
force-pushed
the
bump_shellcheck
branch
2 times, most recently
from
539a7e2
to
d9e5e75
Compare
- Bump shellcheck to v0.10.0 - explicitly disable SC2317 since it's reporting many false positives for us (we have helper functions that are only indirectly called in subshells for parallel executions but shellcheck is currently not able to follow them and so it's reporting the commands in the helper functions as unreachable) Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
tiraboschi
force-pushed
the
bump_shellcheck
branch
from
d9e5e75
to
873eecd
Compare
nunnatsa
approved these changes
May 29, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nunnatsa, tiraboschi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
many false positives for us (we have helper functions
that are only indirectly called in subshells for
parallel executions but shellcheck is currently not able
to follow them and so it's reporting the commands
in the helper functions as unreachable)
Release note: