Chore: Update dependencies and remove unneeded ones #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
release-note
|
/retest |
akrejcir
force-pushed
the
update-all-deps
branch
from
f5dcf75
to
6c0adbf
Compare
Closed
0xFelix
reviewed
Mar 6, 2023
| if reviewJson, err := json.Marshal(review); err == nil { | ||
| log.Log.V(8).Infof("admission review:\n%s", string(reviewJson)) | ||
| } else { | ||
| log.Log.V(8).Infof("admission review:\nCould not marshall review to json: %s", err.Error()) |
There was a problem hiding this comment.
Can you dump out the review with %v?
There was a problem hiding this comment.
I think json is easier to read. %v is more verbose, I think it prints types of fields and addresses of pointers.
akrejcir
force-pushed
the
update-all-deps
branch
from
6c0adbf
to
b822e98
Compare
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0xFelix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/retest |
1 similar comment
|
/retest |
kubevirt-bot
added
the
do-not-merge/work-in-progress
akrejcir
force-pushed
the
update-all-deps
branch
from
b822e98
to
a9102b2
Compare
kubevirt-bot
removed
the
do-not-merge/work-in-progress
|
/retest |
kubevirt-bot
added
the
needs-rebase
Updated kubevirt modules to v0.59.0 and CDI to v1.55.2 Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
Updated k8s.io to v0.26.2 and controller runtime to v0.14.5. Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
Updated: - github.com/onsi/ginkgo/v2 - github.com/onsi/gomega - github.com/operator-framework/api - github.com/operator-framework/operator-lib - github.com/spf13/cobra - sigs.k8s.io/kustomize/api Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
Removed direct dependency on: - github.com/davecgh/go-spew - github.com/ghodss/yaml - github.com/pkg/errors - gopkg.in/yaml.v2 Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
The library was only used for its logger. Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
akrejcir
force-pushed
the
update-all-deps
branch
from
a9102b2
to
8718e02
Compare
kubevirt-bot
removed
the
needs-rebase
|
Kudos, SonarCloud Quality Gate passed!
|
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Update
go.moddependencies.Release note: